Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Angular 16 #84

Merged
merged 6 commits into from
Sep 10, 2023
Merged

Upgrade to Angular 16 #84

merged 6 commits into from
Sep 10, 2023

Conversation

gethari
Copy link

@gethari gethari commented Sep 1, 2023 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ x ] The commit message follows our guidelines: CONTRIBUTING.md#commit
  • [ x ] Tests for the changes have been added (for bug fixes / features)
  • [ x ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ x ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

  • Upgraded lib to support Angular 16
  • Upgraded all dependencies to latest stable version

Does this PR introduce a breaking change?

[  ] Yes
[ x ] No

@stackblitz
Copy link

stackblitz bot commented Sep 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@gethari
Copy link
Author

gethari commented Sep 1, 2023 •
edited
Loading

@NetanelBasal I also need the lib without @angular/material #82 dependency, any thoughts about how to go about it ? Should I directly remove it from dependencies and use @ng-bootstrap/ng-bootstrap for the Modal ?

@gethari
Copy link
Author

gethari commented Sep 5, 2023

@NetanelBasal would appreciate any inputs here, please

@gethari gethari mentioned this pull request Sep 6, 2023
Closed
@NetanelBasal
Copy link
Member

Sure

@gethari
Copy link
Author

gethari commented Sep 6, 2023 •
edited
Loading

@NetanelBasal thank you, it is done, after new changes the modal looks like this.

image

@NetanelBasal
Copy link
Member

Can you please follow the commit guidance and add a breaking change?

@gethari
Copy link
Author

gethari commented Sep 7, 2023

@NetanelBasal sorry for inconvenience, I think I have added a breaking change. Can you please check now ?

@NetanelBasal
Copy link
Member

I don't see. Please use npm run commit and follow the questions

refactor: 💡 Remove Angular material and use bootstrap
bc7be48 
Earlier the library used @angular/material as a dependency, due to which
many people may not need the whole material package & may already be
using bootstrap, so used ng-bootstrap

BREAKING CHANGE: 🧨 Replaced @angular/material with @ng-bootstrap/ng-bootstrap

✅ Closes: #83
@gethari
Copy link
Author

gethari commented Sep 7, 2023

I don't see. Please use npm run commit and follow the questions

Thank you for showing me the way npm run commit , I was not used to committing like this earlier, good to know that there's a package for handling these kind of things. Nice learning 💡 for me. I think it should be good to go now.

@gethari
Copy link
Author

gethari commented Sep 7, 2023

Looks like the tests are failing, I will try to fix them

@gethari
Copy link
Author

gethari commented Sep 8, 2023

@NetanelBasal can you please check now, I have fixed the tests

@NetanelBasal NetanelBasal merged commit d8da957 into ngneat:master Sep 10, 2023
1 check passed
@gethari
Copy link
Author

gethari commented Sep 11, 2023

Thanks for the quick action @netanel-utila & @NetanelBasal , could you please publish the 1.4.x version ? I couldn't able to find it on releases ?

@NetanelBasal
Copy link
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netanel-utila netanel-utila netanel-utila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gethari @NetanelBasal @netanel-utila