Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dependencies): removing @ng-bootstrap/ng-bootstrap from the dependencies #90

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

Pilpin
Copy link
Contributor

@Pilpin Pilpin commented Mar 1, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe: removed a dependency on @ng-bootstrap/ng-bootstrap

What is the current behavior?

@ng-bootstrap/ng-bootstrap is needed

Issue Number: 89

What is the new behavior?

@ng-bootstrap/ng-bootstrap is not needed anymore

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Users using ng-bootstrap should add ref.componentInstance.dismiss.subscribe(() => ref.close()); to their registerHelpModal function.

Copy link

stackblitz bot commented Mar 1, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NetanelBasal NetanelBasal merged commit aac1fc2 into ngneat:master Mar 2, 2024
1 check passed
@boop5
Copy link

boop5 commented Mar 12, 2024

@NetanelBasal is there a particular reason this fix is not pushed to npm yet? I'd really like to replace my @HostListeners with this lib🔥

thanks

@NetanelBasal
Copy link
Member

This is a breaking change so I'm waiting for this https://github.com/ngneat/hotkeys/pull/91/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants