Fix assertion failure parsing invalid physical literal

nickg · Jul 23, 2023 · fceb07d · fceb07d
1 parent fdc75c2
commit fceb07d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/common.c b/src/common.c
@@ -368,6 +368,9 @@ bool parse_value(type_t type, const char *str, parsed_value_t *value)
             *p = toupper_iso88591(*p);
          *p = '\0';
 
+         if (p == copy)
+            return false;
+
          ident_t id = ident_new(copy);
 
          value->integer = -1;

diff --git a/test/test_value.c b/test/test_value.c
@@ -180,6 +180,8 @@ START_TEST(test_physical)
 
    fail_unless(parse_value(t, " 3   ps ", &v));
    ck_assert_int_eq(v.integer, 3000);
+
+   fail_if(parse_value(t, " 5", &v));
 }
 END_TEST