Add NULL check before calling type_eq. #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickg
reviewed
Nov 2, 2024
NikLeberg
force-pushed
the
fuzz_1725b8e
branch
from
31cadd6
to
9102140
Compare
nickg
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the fuzzing crashes found by @avelure.
See #1038 (comment).
This one happened when
type_eqwas called on akindthat is actuallyNULL. I added a simple check. The tests withmake checkare passing and seem to indicate that nothing else was impacted. Lets see what CI thinks of it.I preliminary merged #1048 to build upon the same test case. I'll rebase once that is in master.
Cheers