Update minimum supported Swift version to Swift 5.7 #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase it's too long or multiline
…erty has optional type
…e property's type is an existential, or if the RHS value has an infix operator
…ivate declarations (nicklockwood#1750) Co-authored-by: Cal Stephens <[email protected]>
…s after MARK comments (nicklockwood#1770)
…secutive groups of properties (nicklockwood#1795)
nicklockwood
force-pushed
the
develop
branch
14 times, most recently
from
89c1701 to
3cbdb99
Compare
nicklockwood
force-pushed
the
develop
branch
9 times, most recently
from
cae4d67 to
f36187b
Compare
nicklockwood
force-pushed
the
develop
branch
2 times, most recently
from
8b0b9d0 to
a608072
Compare
nicklockwood
force-pushed
the
develop
branch
4 times, most recently
from
f9e5a79 to
112174a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the current set of CI jobs, SwiftFormat currently supports a minimum Swift version of Swift 5.2, which was released in Feb 2020.
In #1832, we had been talking about using multiple-trailing-closure syntax for a new feature. Multiple trailing closures were introduced in Swift 5.3, so to use this approach we have to update the minimum supported Swift version.
@nicklockwood, what are your general thoughts on what Swift versions should be supported by SwiftFormat?
We could just update to Swift 5.3+, which would lets us use trailing closures. I personally like the sound of Swift 5.7, since it adds a lot of extra functionality that we're missing in Swift 5.2 while still being somewhat older (released in September 2022).