Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Consider warnings as errors when running pytest #1370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhlegarreta
Copy link
Contributor

Consider warnings as errors when running pytest: add the strict-warnings flag to pytest to consider warnings as errors.

@oesteban oesteban enabled auto-merge January 13, 2025 09:25
@oesteban
Copy link
Member

pytest: error: unrecognized arguments: --strict-warnings
  inifile: /src/mriqc/pyproject.toml
  rootdir: /src/mriqc

@jhlegarreta
Copy link
Contributor Author

Yes, there is efforts across other NiPreps repositories to enforce this as well, e.g.
nipreps/nireports#157
nipreps/nifreeze#40

Only the latter seems to be working. There is a discussion with Chris on the nireports PR. It may be worthwhile going over this during the next tech meeting to avoid accumulating technical debt.

PS: Unrelated to the topic and suitable for a tech meeting: should the default branch be renamed to main for the sake of consistency with modern practices/other NiPreps repositories?

auto-merge was automatically disabled March 1, 2025 22:53

Head branch was pushed to by a user without write access

@jhlegarreta jhlegarreta force-pushed the TreatWarningsAsErrors branch 2 times, most recently from 00dbfba to 92276ca Compare March 1, 2025 23:14
Consider warnings as errors when running `pytest`.
@jhlegarreta jhlegarreta force-pushed the TreatWarningsAsErrors branch from 92276ca to e43650f Compare March 1, 2025 23:15
@jhlegarreta
Copy link
Contributor Author

The CircleCI build error seems to be unrelated:
https://app.circleci.com/pipelines/github/nipreps/mriqc/1726/workflows/0319bd79-0c48-43be-9d23-5bd2a953e62d/jobs/10512?invite=true#step-111-53041_161

The URL seems to exist:
https://app.circleci.com/pipelines/github/nipreps/mriqc/1726/workflows/0319bd79-0c48-43be-9d23-5bd2a953e62d/jobs/10512

I ignore why curl is failing.

Until we solved that, I cannot provide evidence that the patch set in this PR works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants