Switch to using std::ascii::escape_default#39
Open
Pr0methean wants to merge 2 commits intonjaard:masterfrom
Open
Switch to using std::ascii::escape_default#39Pr0methean wants to merge 2 commits intonjaard:masterfrom
Pr0methean wants to merge 2 commits intonjaard:masterfrom
Conversation
This will escape all non-ASCII bytes, rather than just the allowlisted special characters.
Owner
|
Hi @Pr0methean and thank you for your contribution. Can you explain why you would like to make this change? Also, it seems like it will have a significant performance by having to allocate for the |
Author
|
The idea is that it'll be possible to print an escape string with only ASCII characters, meaning it can be included in code that's of any 8-bit encoding, and used in contexts such as a |
…or escape sequence
Author
Fixed in 41637aa to no longer allocate explicitly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will escape all non-ASCII bytes, rather than just the allowlisted special characters.