Skip to content

Switch to using std::ascii::escape_default #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pr0methean wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Switch to using std::ascii::escape_default #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dd585c
Switch to using std::ascii::escape_default
Pr0methean May 3, 2024
41637aa
Optimization: check for non-ASCII character before allocating space f…
Pr0methean Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions escape_string/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,24 +150,11 @@ pub fn escape<'a>(text: &'a str) -> Cow<'a, str> {
let mut owned = None;

for pos in 0..bytes.len() {
let special = match bytes[pos] {
0x07 => Some(b'a'),
0x08 => Some(b'b'),
b'\t' => Some(b't'),
b'\n' => Some(b'n'),
0x0b => Some(b'v'),
0x0c => Some(b'f'),
b'\r' => Some(b'r'),
b' ' => Some(b' '),
b'\\' => Some(b'\\'),
_ => None,
};
if let Some(s) = special {
if !(bytes[pos] as char).is_ascii() {
if owned.is_none() {
owned = Some(bytes[0..pos].to_owned());
}
owned.as_mut().unwrap().push(b'\\');
owned.as_mut().unwrap().push(s);
owned.as_mut().unwrap().expand(std::ascii::escape_default(bytes[pos]));
} else if let Some(owned) = owned.as_mut() {
owned.push(bytes[pos]);
}
Expand Down