Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from esm to @httptoolkit/esm #38

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Conversation

pimterry
Copy link
Collaborator

Fixes #37. I've just reused the @types/esm types here, since they should be the same and I haven't worked out how to modify esm to add them in easily directly over there (the build & publish setup is much more complicated than you'd expect).

This change also removes workarounds here that I think were since fixed within esm-wallaby (here and here specifically).

I don't have any specific interesting test cases to confirm those, but I can do things like require('.')('node:fs') with no problem, and everything works correctly for other modules, so I assume that's all working nicely now.

Copy link

sonarcloud bot commented Dec 15, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9502085) 100.00% compared to head (1ee105d) 97.72%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #38      +/-   ##
===========================================
- Coverage   100.00%   97.72%   -2.28%     
===========================================
  Files            4        4              
  Lines           45       44       -1     
  Branches         7        7              
===========================================
- Hits            45       43       -2     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nktnet1
Copy link
Owner

nktnet1 commented Dec 15, 2023

Looks good to me - thanks @pimterry!

@nktnet1 nktnet1 merged commit f60e076 into nktnet1:main Dec 15, 2023
8 of 9 checks passed
nktnet1 added a commit that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't import some modules
2 participants