-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: use unusual chars in the path to ensure our tests are robust #48409
base: main
Are you sure you want to change the base?
The head ref may contain hidden characters: "\u2020\u00A3\u00A7\u2122"
Conversation
Review requested:
|
TIL GNU Make does not support files containing whitespaces nor |
Should we maybe avoid the hidden characters? I guess it's ok if GH only warns about them now but I don't want to see a permanent warning on the repo. |
I'm pretty sure it's just about the branch name for this PR, not related to the content of this PR. console.log("\u2020\u00A3\u00A7\u2122" === '†£§™'); // true |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48409 +/- ##
==========================================
- Coverage 88.41% 88.41% -0.01%
==========================================
Files 653 653
Lines 187437 187437
Branches 36079 36075 -4
==========================================
- Hits 165730 165721 -9
- Misses 14948 14952 +4
- Partials 6759 6764 +5 |
a5e5921
to
c8b19c2
Compare
@@ -40,6 +40,7 @@ jobs: | |||
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 | |||
with: | |||
persist-credentials: false | |||
path: node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why node isn't checked out directly into the weird path characters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, #48409 (comment)
78ec699
to
1c336ad
Compare
28f4e8f
to
f15213d
Compare
Hopefully our tests should work without assuming the repo is cloned in path that contains unusual chars.