Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use unusual chars in the path to ensure our tests are robust #48409

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 10, 2023

Hopefully our tests should work without assuming the repo is cloned in path that contains unusual chars.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 10, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Jun 10, 2023

TIL GNU Make does not support files containing whitespaces nor %, that's… unexpected.

@targos
Copy link
Member

targos commented Jun 25, 2023

Should we maybe avoid the hidden characters? I guess it's ok if GH only warns about them now but I don't want to see a permanent warning on the repo.

@aduh95
Copy link
Contributor Author

aduh95 commented Jun 25, 2023

Should we maybe avoid the hidden characters? I guess it's ok if GH only warns about them now but I don't want to see a permanent warning on the repo.

I'm pretty sure it's just about the branch name for this PR, not related to the content of this PR.

console.log("\u2020\u00A3\u00A7\u2122" === '†£§™'); // true

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (47ad609) to head (522b401).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #48409      +/-   ##
==========================================
- Coverage   88.41%   88.41%   -0.01%     
==========================================
  Files         653      653              
  Lines      187437   187437              
  Branches    36079    36075       -4     
==========================================
- Hits       165730   165721       -9     
- Misses      14948    14952       +4     
- Partials     6759     6764       +5     

see 26 files with indirect coverage changes

@aduh95 aduh95 force-pushed the †£§™ branch 3 times, most recently from a5e5921 to c8b19c2 Compare September 25, 2024 22:12
@@ -40,6 +40,7 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
with:
persist-credentials: false
path: node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why node isn't checked out directly into the weird path characters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aduh95 aduh95 force-pushed the †£§™ branch 2 times, most recently from 78ec699 to 1c336ad Compare September 29, 2024 21:26
@aduh95 aduh95 force-pushed the †£§™ branch 2 times, most recently from 28f4e8f to f15213d Compare October 18, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants