doc: clarify that CQ only picks up PRs targeting main
#60731
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
aduh95
approved these changes
Nov 15, 2025
Comment on lines
54
to
+58
| 2. A CI must've ran and succeeded since the last change on the PR | ||
| 3. A collaborator must have approved the PR since the last change | ||
| 4. Only Jenkins CI and GitHub Actions are checked (V8 CI and CITGM are ignored) | ||
| 5. The PR must target the `main` branch (PRs opened against other branches, such | ||
| as backport PRs, are ignored) |
Contributor
There was a problem hiding this comment.
Doesn't have to be resolved in this PR, but the use of an ordered list doesn't really make sense here; the style guide we follow says we should use unordered list, and add periods.
Suggested change
| 2. A CI must've ran and succeeded since the last change on the PR | |
| 3. A collaborator must have approved the PR since the last change | |
| 4. Only Jenkins CI and GitHub Actions are checked (V8 CI and CITGM are ignored) | |
| 5. The PR must target the `main` branch (PRs opened against other branches, such | |
| as backport PRs, are ignored) | |
| - A CI must've ran and succeeded since the last change on the PR. | |
| - A collaborator must have approved the PR since the last change. | |
| - Only Jenkins CI and GitHub Actions are checked (V8 CI and CITGM are ignored). | |
| - The PR must target the `main` branch (PRs opened against other branches, such | |
| as backport PRs, are ignored). |
lpinca
approved these changes
Nov 16, 2025
Renegade334
added
author ready
cjihrig
approved these changes
Nov 16, 2025
RafaelGSS
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤦