Skip to content

doc: clarify that CQ only picks up PRs targeting main #60731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

doc: clarify that CQ only picks up PRs targeting main #60731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/contributing/commit-queue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ of the commit queue:
2. A CI must've ran and succeeded since the last change on the PR
3. A collaborator must have approved the PR since the last change
4. Only Jenkins CI and GitHub Actions are checked (V8 CI and CITGM are ignored)
5. The PR must target the `main` branch (PRs opened against other branches, such
as backport PRs, are ignored)
Comment on lines 54 to +58
Copy link
Contributor

@aduh95 aduh95 Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't have to be resolved in this PR, but the use of an ordered list doesn't really make sense here; the style guide we follow says we should use unordered list, and add periods.

Suggested change
2. A CI must've ran and succeeded since the last change on the PR
3. A collaborator must have approved the PR since the last change
4. Only Jenkins CI and GitHub Actions are checked (V8 CI and CITGM are ignored)
5. The PR must target the `main` branch (PRs opened against other branches, such
as backport PRs, are ignored)
- A CI must've ran and succeeded since the last change on the PR.
- A collaborator must have approved the PR since the last change.
- Only Jenkins CI and GitHub Actions are checked (V8 CI and CITGM are ignored).
- The PR must target the `main` branch (PRs opened against other branches, such
as backport PRs, are ignored).


## Implementation

Expand Down
Loading