feat(ui): add DataTag
#7797
Merged
feat(ui): add DataTag
#7797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new UI component called CircularIcon that displays a circular icon with customizable symbol, color, and size. Key changes include:
- Adding the CircularIcon component in TypeScript.
- Including a Storybook story to demonstrate various icon sizes.
- Adding a CSS module for styling the component with Tailwind CSS utilities.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/ui-components/Common/CircularIcon/index.tsx | Adds the CircularIcon component implementation. |
| packages/ui-components/Common/CircularIcon/index.stories.tsx | Provides Storybook stories for the CircularIcon. |
| packages/ui-components/Common/CircularIcon/index.module.css | Implements the styling for the CircularIcon component using CSS modules. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7797 +/- ##
==========================================
+ Coverage 75.34% 75.46% +0.11%
==========================================
Files 96 101 +5
Lines 7862 8309 +447
Branches 192 218 +26
==========================================
+ Hits 5924 6270 +346
- Misses 1937 2037 +100
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
canerakdas
reviewed
May 31, 2025
Co-authored-by: Caner Akdas <[email protected]> Signed-off-by: Aviv Keller <[email protected]>
avivkeller
commented
May 31, 2025
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
github-actions
bot
removed
the
github_actions:pull-request
canerakdas
reviewed
Jun 1, 2025
avivkeller
added
fast-track
github-actions
bot
removed
the
github_actions:pull-request
|
Fast-tracking so I can add this to the web generator. If you approve, merge when ready. |
ovflowd
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the
CircularIconcomponent, based on the design shown below:Storybook preview: