-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat(ui): add DataTag
#7797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat(ui): add DataTag
#7797
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
adf9b80
feat(ui): add CircularIcon
avivkeller 06458b8
tw in story
avivkeller a21a809
Apply suggestions from code review
avivkeller 082cdd1
fixup!
avivkeller d1d404f
rename
avivkeller b9aed99
code review
avivkeller 7e2faf1
code review
avivkeller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
27 changes: 27 additions & 0 deletions
27
packages/ui-components/Common/CircularIcon/index.module.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| @reference "../../styles/index.css"; | ||
|
|
||
| .icon { | ||
| @apply flex | ||
| items-center | ||
| justify-center | ||
| rounded-full | ||
| font-semibold | ||
| text-white; | ||
|
|
||
| &.lg { | ||
| @apply h-12 | ||
| w-12 | ||
| text-2xl; | ||
| } | ||
|
|
||
| &.md { | ||
| @apply h-10 | ||
| w-10 | ||
avivkeller marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| text-xl; | ||
| } | ||
|
|
||
| &.sm { | ||
| @apply h-8 | ||
| w-8; | ||
avivkeller marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
18 changes: 18 additions & 0 deletions
18
packages/ui-components/Common/CircularIcon/index.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import type { Meta as MetaObj, StoryObj } from '@storybook/react'; | ||
|
|
||
| import CircularIcon from '#ui/Common/CircularIcon'; | ||
|
|
||
| type Story = StoryObj<typeof CircularIcon>; | ||
| type Meta = MetaObj<typeof CircularIcon>; | ||
|
|
||
| export const Icons: Story = { | ||
| render: () => ( | ||
| <div className="flex items-center gap-4"> | ||
| <CircularIcon symbol="B" color="#3b82f6" size="sm" /> | ||
| <CircularIcon symbol="G" color="#10b981" size="md" /> | ||
| <CircularIcon symbol="R" color="#ef4444" size="lg" /> | ||
| </div> | ||
| ), | ||
| }; | ||
|
|
||
| export default { component: CircularIcon } as Meta; |
avivkeller marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import classNames from 'classnames'; | ||
|
|
||
| import styles from './index.module.css'; | ||
|
|
||
| interface CircularIconProps { | ||
AugustinMauroy marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| symbol: string; | ||
| color: string; | ||
avivkeller marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| size?: 'lg' | 'md' | 'sm'; | ||
| } | ||
|
|
||
| export default function CircularIcon({ | ||
| symbol, | ||
| color, | ||
| size = 'md', | ||
| }: CircularIconProps) { | ||
| return ( | ||
| <div | ||
| className={classNames(styles.icon, styles[size])} | ||
| style={{ backgroundColor: color }} | ||
| > | ||
| <span>{symbol}</span> | ||
| </div> | ||
| ); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.