ci: fix test coverage for codecov #4520
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
force-pushed
the
no-coverage-for-wpt
branch
from
183e8cf to
ee0759f
Compare
Uzlopak
changed the title
Uzlopak
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4520 +/- ##
=========================================
+ Coverage 0 92.95% +92.95%
=========================================
Files 0 105 +105
Lines 0 32871 +32871
=========================================
+ Hits 0 30554 +30554
- Misses 0 2317 +2317 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix test coverage reporting for CodeCov by addressing issues with coverage file processing. The changes reorganize test execution order, improve coverage environment variable propagation, and consolidate cache-interceptor tests.
- Reorganizes GitHub Actions workflow test execution order for better coverage collection
- Adds NODE_V8_COVERAGE environment variable propagation to worker processes
- Consolidates sqlite-specific cache interceptor testing into main cache interceptor tests
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/cache-interceptor/cache-tests.mjs | Improves variable naming and adds coverage environment variable propagation to worker processes |
| package.json | Consolidates sqlite cache interceptor test script with main cache interceptor tests |
| .github/workflows/nodejs.yml | Reorganizes test execution order and consolidates cache interceptor tests with conditional sqlite support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeCov has some issues with processing the coverage files. Lets see...
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status