Conversation
kevaundray
reviewed
Apr 21, 2023
Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Contributor
|
Just need to run cargo fmt as I did the suggestion from inside of Github web IDE |
Contributor
|
Lets see if we can get #1114 as the only commit in the next release, by delaying this PR for roughly an hour |
5 tasks
Contributor
|
This PR looks more like what I had in mind with regard to having an explicit else destination without fallthrough. Can you elaborate on the naming though? I suppose "jump if (cond)" is technically not right if we're always jumping and just changing where we jump based on the cond. Similarly though, "branch if (cond)" seems wrong as well for the same reason. Barring a single correct answer, I'd like to keep both the conditional jump and unconditional instructions with similar naming schemes. So either both Jmp or both Br currently. |
TomAFrench
added a commit
that referenced
this pull request
Apr 24, 2023
* master: chore: update flake version to match current release (#1204) feat!: Switch to aztec_backend that uses upstream BB & UltraPlonk (#1114) chore(ssa refactor): Add Context structs and start ssa gen pass (#1196) chore(ssa): Replace JmpIf with BrIf (#1193) chore(noir): Release 0.4.1 (#1164) chore(ssa refactor): Add DenseMap and SparseMap types (#1184) feat: bump noir-source-resolver version (#1182) chore(deps): bump h2 from 0.3.16 to 0.3.18 (#1186) fix(nargo): restore `nargo codegen-verifier` functionality (#1185) chore: simplify setup code in `noir_integration` test (#1180) feat: Add Poseidon-BN254 hash functions (#1176)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JmpIfisn't sufficient for encoding block arguments for the fall through successor. It is also more convenient if block terminator instructions describe all successors, such that we do not have to infer fall throughs from some block ordering.Checklist
cargo fmtwith default settings.Documentation needs
Additional context