Skip to content

feat: add more patterns to unnecessary files hints - #3143

Merged
ghostdevv merged 4 commits into
npmx-dev:mainfrom
gameroman:add-hint-patterns
Aug 7, 2026
Merged

feat: add more patterns to unnecessary files hints#3143
ghostdevv merged 4 commits into
npmx-dev:mainfrom
gameroman:add-hint-patterns

Conversation

@gameroman

Copy link
Copy Markdown
Member

🔗 Linked issue

🧭 Context

📚 Description

@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview Aug 5, 2026 4:25pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Aug 5, 2026 4:25pm
npmx-lunaria Ignored Ignored Aug 5, 2026 4:25pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 84ba1119-f713-430b-a7f5-695ee06ef168

📥 Commits

Reviewing files that changed from the base of the PR and between fe93786 and bd9d4e5.

📒 Files selected for processing (2)
  • app/utils/package-content-hints.ts
  • test/unit/app/utils/package-content-hints.spec.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/unit/app/utils/package-content-hints.spec.ts

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved package content checks by identifying .borp.yaml, commitlint.config.js, and renovate.json files, along with benchmarks directories, as potentially unnecessary content.
  • Tests
    • Added coverage to verify that these files and directories are correctly flagged.

Walkthrough

The package content hint lists now include .borp.yaml, commitlint.config.js, renovate.json, and benchmarks. Unit tests verify matching for each added pattern.

Changes

Package content hint detection

Layer / File(s) Summary
Add unnecessary content patterns and tests
app/utils/package-content-hints.ts, test/unit/app/utils/package-content-hints.spec.ts
The hint lists include three additional unnecessary file patterns and the benchmarks directory pattern. Unit tests verify positive matches for all added patterns.

Possibly related PRs

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description contains only a template and does not provide meaningful details about the changes. Complete the description with the change context, implementation summary, rationale, and test details.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the addition of patterns to unnecessary-file hints and follows the conventional commit format.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@gameroman
gameroman added this pull request to the merge queue Aug 6, 2026
'.gitattributes',
'.travis.yml',
'.verb.md',
'.borp.yaml',

@ghostdevv ghostdevv Aug 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this? xD

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 6, 2026
@gameroman
gameroman added this pull request to the merge queue Aug 6, 2026
@gameroman
gameroman requested a review from ghostdevv August 6, 2026 18:05
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 6, 2026
@ghostdevv
ghostdevv added this pull request to the merge queue Aug 7, 2026
Merged via the queue into npmx-dev:main with commit 4836e9b Aug 7, 2026
24 checks passed
@gameroman
gameroman deleted the add-hint-patterns branch August 7, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants