Skip to content

feat: add more patterns to unnecessary files hints #3143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostdevv merged 4 commits into from
Aug 7, 2026
Merged

feat: add more patterns to unnecessary files hints #3143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06b69ba
feat: add more patterns to unnecessary files hints
gameroman Aug 5, 2026
c3e4aff
feat: add more patterns to unnecessary files hints
gameroman Aug 5, 2026
fe93786
feat: add more patterns to unnecessary files hints
gameroman Aug 5, 2026
bd9d4e5
feat: add more patterns to unnecessary files hints
gameroman Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/utils/package-content-hints.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,12 @@ const POSSIBLY_UNNECESSARY_FILES: ReadonlySet<string> = new Set([
'.gitattributes',
'.travis.yml',
'.verb.md',
'.borp.yaml',

@ghostdevv ghostdevv Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this? xD

@gameroman gameroman Aug 6, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found in one of packages

https://main.npmx.dev/package-code/avvio/v/9.3.0/.borp.yaml

'Makefile',
'tsconfig.json',
'jsconfig.json',
'commitlint.config.js',
'renovate.json',
'.node-version',
'.nvmrc',
'mise.toml',
Expand Down Expand Up @@ -63,6 +66,7 @@ const POSSIBLY_UNNECESSARY_DIRECTORIES: ReadonlySet<string> = new Set([
'example',
'examples',
'benchmark',
'benchmarks',
])

const POSSIBLY_UNNECESSARY_DIRECTORY_PATTERNS: readonly RegExp[] = [/^__.+__$/]
Expand Down
4 changes: 4 additions & 0 deletions test/unit/app/utils/package-content-hints.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ describe('isPossiblyUnnecessaryContent', () => {
expect(isPossiblyUnnecessaryContent('.npmignore', 'file')).toBe(true)
expect(isPossiblyUnnecessaryContent('tsconfig.json', 'file')).toBe(true)
expect(isPossiblyUnnecessaryContent('jsconfig.json', 'file')).toBe(true)
expect(isPossiblyUnnecessaryContent('commitlint.config.js', 'file')).toBe(true)
expect(isPossiblyUnnecessaryContent('renovate.json', 'file')).toBe(true)
})

it('flags local environment files', () => {
Expand All @@ -36,6 +38,7 @@ describe('isPossiblyUnnecessaryContent', () => {
it('flags editor and CI files', () => {
expect(isPossiblyUnnecessaryContent('.travis.yml', 'file')).toBe(true)
expect(isPossiblyUnnecessaryContent('.verb.md', 'file')).toBe(true)
expect(isPossiblyUnnecessaryContent('.borp.yaml', 'file')).toBe(true)
expect(isPossiblyUnnecessaryContent('Makefile', 'file')).toBe(true)
expect(isPossiblyUnnecessaryContent('.DS_Store', 'file')).toBe(true)
})
Expand Down Expand Up @@ -176,6 +179,7 @@ describe('isPossiblyUnnecessaryContent', () => {

it('flags development directories', () => {
expect(isPossiblyUnnecessaryContent('benchmark', 'directory')).toBe(true)
expect(isPossiblyUnnecessaryContent('benchmarks', 'directory')).toBe(true)
})

it('flags example directories', () => {
Expand Down
Loading