Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI build #159

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Fix CI build #159

merged 3 commits into from
Sep 4, 2023

Conversation

piotr-roslaniec
Copy link

@piotr-roslaniec piotr-roslaniec commented Aug 31, 2023

Type of PR:

  • Other

Required reviews:

  • 1

What this does:

  • Installs wasm-pack from a precompiled binary
  • Fixes a linting issue on Rust stable

Why it's needed:

  • Some child dependencies in wasm-pack an wasm-opt get updated from time to time and that causes MSRV float
  • With these changes, we should be able to avoid that in the future, and hence avoid CI breaking from time to time

@piotr-roslaniec piotr-roslaniec changed the title chore(ci): set msrv for wasm tools on ci Fix CI build Aug 31, 2023
@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review August 31, 2023 20:46
@cygnusv
Copy link
Member

cygnusv commented Aug 31, 2023

Some child dependencies in wasm-pack an wasm-opt get updated from time to time and that causes MSRV float

Isn't it possible to pin all child dependencies somehow?

@piotr-roslaniec
Copy link
Author

@cygnusv It's not a dependency of any crate, it's a utility installed on CI to compile & run WASM tests.

@cygnusv cygnusv merged commit 0a73aa3 into main Sep 4, 2023
9 checks passed
@piotr-roslaniec piotr-roslaniec deleted the set-msrv-wasm-tools branch September 4, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants