Add a public key field to the Participant struct #77

piotr-roslaniec · 2023-05-04T10:44:53Z

Ferveo's public keys are required to perform aggregate verification
Added a mapping from the provider address to FerveoPublicKey bytes
Downstream changes required:
- Source ritual validator public keys from Coordinator contract taco-web#234
- Register participant's FerveoPublicKey in Coordinator contract nucypher#3167
Documented possible extension in: Set participant public key during transcript aggregations #95
Required reviews: 2

contracts/contracts/coordination/Coordinator.sol

KPrasch · 2023-05-06T19:53:09Z

I'm curious what's compelling us to put ferveo public keys onchain specifically? As of nucypher@dkg-dev-2 these keys are known to participants by using P2P/node discovery which can be interpreted as a duplicated effort?

piotr-roslaniec · 2023-05-08T13:14:57Z

are known to participants by using P2P/node discovery

We also need to make this information ([Transcript, PublicKey] pairs) available to anyone who wants to verify the aggregate (Bob).

It feels somewhat redundant, but it should have the same availability guarantees as Transcript itself.

I'm interested to see whether an alternative design is possible.

derekpierre · 2023-05-09T13:12:19Z

We also need to make this information ([Transcript, PublicKey] pairs) available to anyone who wants to verify the aggregate (Bob).

The ability to verify without having to learn about the network is advantageous. Learning is a very involved process. A web-based Bob would be able to verify without needing to learn.

@KPrasch it would also save us (on the Python-side) from needing Ursula objects for this code: https://github.com/nucypher/nucypher/blob/development/nucypher/characters/lawful.py#L696

piotr-roslaniec · 2023-05-10T06:34:10Z

Notes from a discussion on Discord voice:

It's not possible to counterfeit (Transcript, PublicKey) pair. And so, we only need to provide DA for the Transcript. PublicKey can provide separately without compromising the security of aggregate verification.
Putting PublicKey on-chain is a naive design
An alternative design: Make it available through Porter, and when Porter is deprecated, use the same method od PublicKey discovery to communicate directly with nodes

@KPrasch @derekpierre

KPrasch · 2023-06-07T07:36:16Z

Another consideration here is if we want to derive new keys for each participant+ritual. Otherwise, if nodes only have one long-term ferveo keypair, there's no sense it writing it to the Participant struct.

piotr-roslaniec · 2023-06-28T13:41:13Z

Otherwise, if nodes only have one long-term ferveo keypair, there's no sense it writing it to the Participant struct.

In that case, mapping could be better (updated).

contracts/contracts/coordination/Coordinator.sol

piotr-roslaniec · 2023-07-04T13:21:00Z

I just need 2 approvals so I'm going to ahead and merge if that sounds ok

contracts/contracts/coordination/Coordinator.sol

cygnusv · 2023-07-06T14:21:52Z

contracts/contracts/coordination/Coordinator.sol

@@ -30,6 +30,8 @@ contract Coordinator is AccessControlDefaultAdminRules {
    event TimeoutChanged(uint32 oldTimeout, uint32 newTimeout);
    event MaxDkgSizeChanged(uint16 oldSize, uint16 newSize);

+    event ParticipantPublicKeySet(address indexed participant, BLS12381.G1Point publicKey);


Isn't this a G2 point?

derekpierre · 2023-07-06T14:03:07Z

contracts/contracts/coordination/Coordinator.sol

@@ -61,10 +63,17 @@ contract Coordinator is AccessControlDefaultAdminRules {
        Participant[] participant;
    }

+    struct ParticipantKey {
+        uint32 ritualId;


Is this more like fromRitualId or ... something similar?

derekpierre · 2023-07-06T14:04:28Z

contracts/contracts/coordination/Coordinator.sol

+        ParticipantKey memory newRecord = ParticipantKey(lastRitualId, _publicKey);
+        keysHistory[provider].push(newRecord);
+
+        emit ParticipantPublicKeySet(provider, _publicKey);


Is it beneficial to include the ("startiing from") ritual id in the event?

Could simplify filtering
✔️

derekpierre · 2023-07-06T14:10:06Z

contracts/contracts/coordination/Coordinator.sol

+        emit ParticipantPublicKeySet(provider, _publicKey);
+    }
+
+    function getProviderPublicKey(address _address, uint _ritualId) public view returns (BLS12381.G1Point memory) {


If this function is not called by the other functions in the contract i.e. only called from an external entitiy, I believe using external instead saves a copy step of arguments.

Also, let's call the parameter _provider.

Suggested change

function getProviderPublicKey(address _address, uint _ritualId) public view returns (BLS12381.G1Point memory) {

function getProviderPublicKey(address _provider, uint _ritualId) external view returns (BLS12381.G1Point memory) {

derekpierre · 2023-07-06T14:28:38Z

tests/test_coordinator.py

@@ -130,10 +143,22 @@ def test_initiate_ritual(coordinator, nodes, initiator, erc20, flat_rate_fee_mod
    assert coordinator.getRitualState(0) == RitualState.AWAITING_TRANSCRIPTS


+def test_test_provider_public_key(coordinator, nodes):


Typo?:

Suggested change

def test_test_provider_public_key(coordinator, nodes):

def test_provider_public_key(coordinator, nodes):

KPrasch

👨🏻‍🚀

cygnusv

Great work @piotr-roslaniec. An additional idea from a discussion with @KPrasch: what a about adding the ritual public key as part of the post transcript TX?

Piggy-backing from the post transcript TX simplifies things, maybe we can make it an optional parameter in case the the node needs to set the key. Less TXs means simpler client code, less problems.
Prepares API for when/if Ferveo keys are generated per-ritual.
Code definitely would look uglier, but I think this is bearable considering Coordinator is for the private beta release.

If this sounds good, we can do this in a separate PR, no need to do it here.

derekpierre

🎸

piotr-roslaniec · 2023-07-08T06:58:39Z

Documented possible extension in: #95

jdbertron · 2023-07-14T03:51:41Z

Another consideration here is if we want to derive new keys for each participant+ritual. Otherwise, if nodes only have one long-term ferveo keypair, there's no sense it writing it to the Participant struct.

I don't follow.

piotr-roslaniec requested a review from cygnusv May 4, 2023 10:44

piotr-roslaniec mentioned this pull request May 4, 2023

tDec epic - alpha release tracker nucypher/taco-web#197

Merged

derekpierre reviewed May 4, 2023

View reviewed changes

contracts/contracts/coordination/Coordinator.sol Outdated Show resolved Hide resolved

derekpierre requested a review from KPrasch May 15, 2023 12:57

piotr-roslaniec mentioned this pull request May 18, 2023

Allow nodes to specify the "[decryption] request encrypting key" for E2EE threshold decryption requests #80

Merged

derekpierre mentioned this pull request Jun 14, 2023

Get dFrag and unblinding trinket via public API and separate runtime nucypher/nucypher#3074

Closed

piotr-roslaniec force-pushed the participant-pk branch from 030b339 to 74f6e5e Compare June 28, 2023 12:04

piotr-roslaniec mentioned this pull request Jun 29, 2023

Implement local ritual verification nucypher/taco-web#232

Closed

piotr-roslaniec force-pushed the participant-pk branch from b0e7999 to 9bf8022 Compare June 30, 2023 13:15

piotr-roslaniec changed the base branch from main to development June 30, 2023 13:16

piotr-roslaniec force-pushed the participant-pk branch from 9bf8022 to 48d5794 Compare June 30, 2023 13:39

piotr-roslaniec requested a review from vzotova July 3, 2023 07:06

piotr-roslaniec marked this pull request as ready for review July 3, 2023 07:41

piotr-roslaniec mentioned this pull request Jul 3, 2023

Source ritual validator public keys from Coordinator contract nucypher/taco-web#234

Closed

cygnusv reviewed Jul 3, 2023

View reviewed changes

contracts/contracts/coordination/Coordinator.sol Outdated Show resolved Hide resolved

contracts/contracts/coordination/Coordinator.sol Outdated Show resolved Hide resolved

piotr-roslaniec mentioned this pull request Jul 3, 2023

Use static arrays in FerveoPublicKey serialization nucypher/ferveo#136

Merged

theref reviewed Jul 4, 2023

View reviewed changes

contracts/contracts/coordination/Coordinator.sol Outdated Show resolved Hide resolved

piotr-roslaniec mentioned this pull request Jul 4, 2023

Register participant's FerveoPublicKey in Coordinator contract nucypher/nucypher#3167

Closed

vzotova reviewed Jul 4, 2023

View reviewed changes

contracts/contracts/coordination/Coordinator.sol Outdated Show resolved Hide resolved

use mapping to store participant pk

3d69f92

piotr-roslaniec force-pushed the participant-pk branch 2 times, most recently from f4ab924 to d38ed40 Compare July 6, 2023 13:17

track pariticipant public keys across rituals

01dea58

piotr-roslaniec force-pushed the participant-pk branch from d38ed40 to 01dea58 Compare July 6, 2023 13:21

piotr-roslaniec requested review from cygnusv, theref, vzotova and derekpierre July 6, 2023 13:27

cygnusv reviewed Jul 6, 2023

View reviewed changes

derekpierre reviewed Jul 6, 2023

View reviewed changes

apply pr suggestions

867154b

KPrasch approved these changes Jul 7, 2023

View reviewed changes

cygnusv approved these changes Jul 7, 2023

View reviewed changes

derekpierre approved these changes Jul 8, 2023

View reviewed changes

piotr-roslaniec mentioned this pull request Jul 8, 2023

Set participant public key during transcript aggregations #95

Closed

piotr-roslaniec merged commit 3eebc89 into nucypher:development Jul 8, 2023
2 checks passed

piotr-roslaniec deleted the participant-pk branch July 8, 2023 06:58

piotr-roslaniec mentioned this pull request Jul 14, 2023

Register participant's public keys before ritual initialization nucypher/nucypher#3188

Closed

derekpierre mentioned this pull request Sep 20, 2023

v7.0.0 Major feature freeze nucypher/nucypher#3200

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a public key field to the Participant struct #77

Add a public key field to the Participant struct #77

piotr-roslaniec commented May 4, 2023 •

edited

Loading

KPrasch commented May 6, 2023

piotr-roslaniec commented May 8, 2023 •

edited

Loading

derekpierre commented May 9, 2023

piotr-roslaniec commented May 10, 2023

KPrasch commented Jun 7, 2023

piotr-roslaniec commented Jun 28, 2023

piotr-roslaniec commented Jul 4, 2023

cygnusv Jul 6, 2023

piotr-roslaniec Jul 6, 2023

derekpierre Jul 6, 2023

piotr-roslaniec Jul 6, 2023

derekpierre Jul 6, 2023

piotr-roslaniec Jul 6, 2023

derekpierre Jul 6, 2023

piotr-roslaniec Jul 6, 2023

derekpierre Jul 6, 2023

piotr-roslaniec Jul 6, 2023

KPrasch left a comment

cygnusv left a comment

derekpierre left a comment

piotr-roslaniec commented Jul 8, 2023

jdbertron commented Jul 14, 2023

	function getProviderPublicKey(address _address, uint _ritualId) public view returns (BLS12381.G1Point memory) {
	function getProviderPublicKey(address _provider, uint _ritualId) external view returns (BLS12381.G1Point memory) {

		@@ -130,10 +143,22 @@ def test_initiate_ritual(coordinator, nodes, initiator, erc20, flat_rate_fee_mod
		assert coordinator.getRitualState(0) == RitualState.AWAITING_TRANSCRIPTS


		def test_test_provider_public_key(coordinator, nodes):

	def test_test_provider_public_key(coordinator, nodes):
	def test_provider_public_key(coordinator, nodes):

Add a public key field to the Participant struct #77

Add a public key field to the Participant struct #77

Conversation

piotr-roslaniec commented May 4, 2023 • edited Loading

KPrasch commented May 6, 2023

piotr-roslaniec commented May 8, 2023 • edited Loading

derekpierre commented May 9, 2023

piotr-roslaniec commented May 10, 2023

KPrasch commented Jun 7, 2023

piotr-roslaniec commented Jun 28, 2023

piotr-roslaniec commented Jul 4, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KPrasch left a comment

Choose a reason for hiding this comment

cygnusv left a comment

Choose a reason for hiding this comment

derekpierre left a comment

Choose a reason for hiding this comment

piotr-roslaniec commented Jul 8, 2023

jdbertron commented Jul 14, 2023

piotr-roslaniec commented May 4, 2023 •

edited

Loading

piotr-roslaniec commented May 8, 2023 •

edited

Loading