[WIP] API Rework #554
Closed
[WIP] API Rework #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Piotr Roslaniec <[email protected]>
Modify some default values used for creating SIWE message, including use a random nonce.
…used tests to fail. Co-authored-by: Manuel Montenegro <[email protected]>
Fix the URI used for EIP4361 message to be properly formed - it caused an invalid SIWE message to be created.
…are invalid for SIWE.
Run linter.
…61 to be more accurate and in line with EIP712 auth signature call. This can perhaps be an interface/base class method in the future. Run linter.
…rt generic auth-provider
| @@ -202,6 +185,7 @@ export const isAuthorized = async ( | |||
| messageKit, | |||
| ); | |||
|
|
|||
| // TODO is this still valid and actually needed? should we remove this? | |||
There was a problem hiding this comment.
I think it's worthwhile to revisit it post release of @nucypher/contracts - IIRC, there were some changes to EncryptorAllowlist contract, etc.
So we may want to revisit how (if) to expose this logic in taco-web.
piotr-roslaniec
approved these changes
Jul 22, 2024
derekpierre
added a commit
to derekpierre/taco-web
that referenced
this pull request
Jul 22, 2024
…et the ritual so early; obtaining it later saves us from passing additional parameters.
Allow Context to be created with a condition, and subsequently populated with authProviders and customParameters. Make :userAddressExternalEIP4361 a reserved context variable because the context will use the provided authProviders to populate its (and :userAddress) values in the overall context used for decryption.
… replaces authProvider and customParmeters since those are now encompassed in the context itself.
…common elements for both ei4361 provider and single sign-on provider. Move user address context variable for external eip4361 to taco-auth as well. Update relevant imports.
…s the only thing using it.
…d of directly passing auth provider. Expose USER_ADDRESS_PARAM* constants from taco for now.
…viding auth provider.
…roviding authProvider.
derekpierre
added a commit
to derekpierre/taco-web
that referenced
this pull request
Jul 30, 2024
derekpierre
added a commit
to derekpierre/taco-web
that referenced
this pull request
Jul 31, 2024
derekpierre
added a commit
to derekpierre/taco-web
that referenced
this pull request
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Based over #547
ConditionContextinstead of splitting up params for authProvider and customParameters.ConditionContextto be populated by developers with authProviders and customParameters before being used for decryptionIssues fixed/closed:
Why it's needed:
Notes for reviewers: