Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] API Rework #554

Closed
wants to merge 80 commits into from
Closed

[WIP] API Rework #554

wants to merge 80 commits into from

Commits on Jul 2, 2024

  1. move auth methods to taco-auth

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    ae751eb View commit details
    Browse the repository at this point in the history

  2. rewrite eip712 auth

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    ec5ce9a View commit details
    Browse the repository at this point in the history

  3. chore: fix build errors

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b57e3b9 View commit details
    Browse the repository at this point in the history

  4. add a sketch of siwe provider

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    e6de3e3 View commit details
    Browse the repository at this point in the history

  5. Change function name

    @manumonti @piotr-roslaniec
    manumonti authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b7de428 View commit details
    Browse the repository at this point in the history

  6. Expose createSIWEMessage parameters

    @manumonti @piotr-roslaniec
    manumonti authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    919b31f View commit details
    Browse the repository at this point in the history

  7. Use EIP-4361 as Signature Provider

    @manumonti @piotr-roslaniec
    manumonti authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    d67cd13 View commit details
    Browse the repository at this point in the history

  8. Update pnpm-lock file after rebase

    @manumonti @piotr-roslaniec
    manumonti authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b602083 View commit details
    Browse the repository at this point in the history

  9. Add EIP-712 test

    @manumonti @piotr-roslaniec
    manumonti authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    8eca4c4 View commit details
    Browse the repository at this point in the history

  10. Add scheme field to EIP712 message

    @manumonti @piotr-roslaniec
    manumonti authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    d365bba View commit details
    Browse the repository at this point in the history

  11. Generalize TypedSignature interface

    @manumonti @piotr-roslaniec
    manumonti authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    704a08a View commit details
    Browse the repository at this point in the history

  12. Use TypedSignature format as return of SiweMessage

    @manumonti @piotr-roslaniec
    manumonti authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    14c128e View commit details
    Browse the repository at this point in the history

  13. Add tests for SIWE message creation

    @manumonti @piotr-roslaniec
    manumonti authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    4e226db View commit details
    Browse the repository at this point in the history

  14. Add EIP761 and SIWE as context options and tests 

    Co-authored-by: Piotr Roslaniec <[email protected]>
    @manumonti @piotr-roslaniec
    manumonti and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    e986f26 View commit details
    Browse the repository at this point in the history

  15. Replace didtools dependency with a depdency on siwe. 

    Modify some default values used for creating SIWE message, including use a random nonce.
    @derekpierre @piotr-roslaniec
    derekpierre authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    39765fe View commit details
    Browse the repository at this point in the history

  16. Change scheme from "SIWE" to "EIP4361".

    @derekpierre @piotr-roslaniec
    derekpierre authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    0161445 View commit details
    Browse the repository at this point in the history

  17. Fix bug when determining whether condition requires signer or not; ca… 

    …used tests to fail.

Co-authored-by: Manuel Montenegro <[email protected]>
    @derekpierre @manumonti @piotr-roslaniec
    2 people authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b178040 View commit details
    Browse the repository at this point in the history

  18. Run linter.

    @derekpierre @piotr-roslaniec
    derekpierre authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    a200135 View commit details
    Browse the repository at this point in the history

  19. Update userAddressSchema to accomodate additional userAddress auth-sp… 

    …ecific values.
    @derekpierre @piotr-roslaniec
    derekpierre authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    172d9f2 View commit details
    Browse the repository at this point in the history

  20. typedData entry for EIP4361 should be a string. 

    Fix the URI used for EIP4361 message to be properly formed - it caused an invalid SIWE message to be created.
    @derekpierre @piotr-roslaniec
    derekpierre authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    8a1e7ed View commit details
    Browse the repository at this point in the history

  21. Fix fake provider chain id to be a positive number. Negative numbers … 

    …are invalid for SIWE.
    @derekpierre @piotr-roslaniec
    derekpierre authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    5b78082 View commit details
    Browse the repository at this point in the history

  22. Fix/improve tests for taco-auth/context. 

    Run linter.
    @derekpierre @piotr-roslaniec
    derekpierre authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    6af0e23 View commit details
    Browse the repository at this point in the history

  23. chore(linter): fix linter

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    d2eda8b View commit details
    Browse the repository at this point in the history

  24. Change getOrCreateSiweMessage to getOrCreateWalletSignature for EIP43… 

    …61 to be more accurate and in line with EIP712 auth signature call. This can perhaps be an interface/base class method in the future.

Run linter.
    @derekpierre @piotr-roslaniec
    derekpierre authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    da018f2 View commit details
    Browse the repository at this point in the history

  25. set domain and uri in eip4361 dynamically

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    d2b2c80 View commit details
    Browse the repository at this point in the history

  26. Update statement to include a mention of "TACo".

    @derekpierre @piotr-roslaniec
    derekpierre authored and piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    49aa0b2 View commit details
    Browse the repository at this point in the history

  27. fix siwe tests

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    246786e View commit details
    Browse the repository at this point in the history

  28. deduplicate test methods

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    63306a6 View commit details
    Browse the repository at this point in the history

  29. refactor(auth-provider): first pass at refactoring taco-auth to suppo… 

    …rt generic auth-provider
    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    120c0d9 View commit details
    Browse the repository at this point in the history

  30. refactor(auth-provider): introduce generic auth provider

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    c46bb82 View commit details
    Browse the repository at this point in the history

  31. refactor: clean up naming and todos

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    78001fe View commit details
    Browse the repository at this point in the history

  32. test(conditions): document context behavior

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    524dff3 View commit details
    Browse the repository at this point in the history

  33. refactor!(context): remove unused context method

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    8455f9f View commit details
    Browse the repository at this point in the history

  34. refactor!(context): remove unused provider parameter

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    dc91ce0 View commit details
    Browse the repository at this point in the history

  35. refactor!(context): refactor validation and rename public methods

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    7c44a99 View commit details
    Browse the repository at this point in the history

  36. apply pr comments

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    12c7e7a View commit details
    Browse the repository at this point in the history

  37. feat(cond): expose requested params in user facing api

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    2c9ff52 View commit details
    Browse the repository at this point in the history

  38. feat!(cond): remove auth checking from cond expr

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    119f2b9 View commit details
    Browse the repository at this point in the history

  39. refactor: rename methods for consistency

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    62a0f78 View commit details
    Browse the repository at this point in the history

  40. feat(eip4361): allow for reusing siwe messages

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    333fb43 View commit details
    Browse the repository at this point in the history

  41. refactor: don't reuse eip4361 alias

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    7d9f561 View commit details
    Browse the repository at this point in the history

  42. chore: document external eip4361 behavior

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    914be0d View commit details
    Browse the repository at this point in the history

  43. apply pr suggestions

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    baf8942 View commit details
    Browse the repository at this point in the history

  44. feat(auth): set defaults for eip4361 providers

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    dfd96fb View commit details
    Browse the repository at this point in the history

  45. chore: update lockfile

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    5a4d072 View commit details
    Browse the repository at this point in the history

  46. feat!(cond): deprecate eip712 auth provider

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    4fcb8ed View commit details
    Browse the repository at this point in the history

  47. Deprecate EIP712 authentication provider (nucypher#532)

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    e9ce886 View commit details
    Browse the repository at this point in the history

  48. feat(auth): validate user-provided auth signature

    @piotr-roslaniec
    piotr-roslaniec committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    be42ddc View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. apply pr suggestions

    @piotr-roslaniec
    piotr-roslaniec committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    c62ae73 View commit details
    Browse the repository at this point in the history

  2. chore: fix duplicated vitest dependency

    @piotr-roslaniec
    piotr-roslaniec committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    6638c5d View commit details
    Browse the repository at this point in the history

  3. Validate user-provided AuthSignature (nucypher#537)

    @piotr-roslaniec
    piotr-roslaniec committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b3d724d View commit details
    Browse the repository at this point in the history

  4. validate eip4361 siwe message

    @piotr-roslaniec
    piotr-roslaniec committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f9e2030 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. feat(taco): expose auth providers from taco

    @piotr-roslaniec
    piotr-roslaniec committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    9ce1a99 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. feat!(auth): expose eip4361 auth provider in taco api

    @piotr-roslaniec
    piotr-roslaniec committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f452c6a View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. apply pr suggestions

    @piotr-roslaniec
    piotr-roslaniec committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    08367ad View commit details
    Browse the repository at this point in the history

  2. fix test not cathing edge cases

    @piotr-roslaniec
    piotr-roslaniec committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    0fba5c5 View commit details
    Browse the repository at this point in the history

  3. Expose auth providers from taco (nucypher#534)

    @derekpierre
    derekpierre committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    28b3592 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. feat!(auth): remove eip712

    @piotr-roslaniec
    piotr-roslaniec committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    899eba4 View commit details
    Browse the repository at this point in the history

  2. Remove EIP712 authentication method (nucypher#546)

    @piotr-roslaniec
    piotr-roslaniec committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    b689493 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Add a sketch for reusing SIWE message

    @manumonti
    manumonti committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    918dba7 View commit details
    Browse the repository at this point in the history

  2. Use constant for EIP4361 auth scheme instead of string.

    @derekpierre
    derekpierre committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7d787cc View commit details
    Browse the repository at this point in the history

  3. Allow :userAddressExternalEIP4361 context variable wherever :userAddr… 

    …ess is allowed.
    @derekpierre
    derekpierre committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    6d9e8b3 View commit details
    Browse the repository at this point in the history

  4. Add single sign-on EIP4361 auth provider for constructing auth signat… 

    …ures from external SIWE messages.
    @derekpierre
    derekpierre committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7bcb0f9 View commit details
    Browse the repository at this point in the history

  5. Run 'pnpm fix' to address linting issues.

    @derekpierre
    derekpierre committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    6709bf3 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Reuse siwe authentication (nucypher#547)

    @derekpierre
    derekpierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    fc3ddf9 View commit details
    Browse the repository at this point in the history

  2. Simplify calls to retrieveAndDecrypt and retrieve. We don't need to g… 

    …et the ritual so early; obtaining it later saves us from passing additional parameters.
    @derekpierre
    derekpierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    aa9e65e View commit details
    Browse the repository at this point in the history

  3. Allow creation of Context from a message kit. 

    Allow Context to be created with a condition, and subsequently populated with authProviders and customParameters.
Make :userAddressExternalEIP4361 a reserved context variable because the context will use the provided authProviders to populate its (and :userAddress) values in the overall context used for decryption.
    @derekpierre
    derekpierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    6c23e7b View commit details
    Browse the repository at this point in the history

  4. Don't have ConditionExpr build a context, the context can be created … 

    …on its own.
    @derekpierre
    derekpierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e275628 View commit details
    Browse the repository at this point in the history

  5. Allow ConditionContext to be an optional parameter for decryption; it… 

    … replaces authProvider and customParmeters since those are now encompassed in the context itself.
    @derekpierre
    derekpierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e0301b8 View commit details
    Browse the repository at this point in the history

  6. Allow address property to be public for SingleSignOnExternalEIP4361Au… 

    …thProvider.
    @derekpierre
    derekpierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    3f7967c View commit details
    Browse the repository at this point in the history

  7. Update tests to accomodate new architecture for ConditionContext.

    @derekpierre
    derekpierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d9f3481 View commit details
    Browse the repository at this point in the history

  8. Reconfigure taco-auth providers folder to have an eip4361 folder and … 

    …common elements for both ei4361 provider and single sign-on provider.

Move user address context variable for external eip4361 to taco-auth as well.
Update relevant imports.
    @derekpierre
    derekpierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1c92bfd View commit details
    Browse the repository at this point in the history

  9. Move RESERVED_CONTEXT_VARIABLES constant to context module since it i… 

    …s the only thing using it.
    @derekpierre
    derekpierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f3a36c4 View commit details
    Browse the repository at this point in the history

  10. Fix message to be use prefix constant.

    @derekpierre
    derekpierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    cfc9c7e View commit details
    Browse the repository at this point in the history

  11. Update nodejs example used for CI job to pass ConditionContext instea… 

    …d of directly passing auth provider.

Expose USER_ADDRESS_PARAM* constants from taco for now.
    @derekpierre
    derekpierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c808df1 View commit details
    Browse the repository at this point in the history

  12. Appease linter.

    @derekpierre
    derekpierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    790d966 View commit details
    Browse the repository at this point in the history

  13. Fix webpack-5 example to use ConditionContext instead of directly pro… 

    …viding auth provider.
    @derekpierre
    derekpierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    6c3224b View commit details
    Browse the repository at this point in the history

  14. Fix other taco examples to use ConditionContext instead of directly p… 

    …roviding authProvider.
    @derekpierre
    derekpierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d9c8745 View commit details
    Browse the repository at this point in the history

  15. Code cleanup based on RFC for nucypher#554.

    @derekpierre
    derekpierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    9acd772 View commit details
    Browse the repository at this point in the history

  16. Add tests for processing addition of authProviders to ConditionContext.

    @derekpierre
    derekpierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    75e7a63 View commit details
    Browse the repository at this point in the history