Skip to content

Update code to improve readability#19

Open
CT9ARyan wants to merge 2 commits intonus-cs2113-AY2425S1:mainfrom
CT9ARyan:main
Open

Update code to improve readability#19
CT9ARyan wants to merge 2 commits intonus-cs2113-AY2425S1:mainfrom
CT9ARyan:main

Conversation

@CT9ARyan
Copy link
Copy Markdown

No description provided.

public class Contacts0 {

public static final int MAX_ENTITIES = 100;
public static final int NUM_OF_FIELDS = 3;
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job extracting constants

System.out.println("|| Welcome to Contacts!");
System.out.println("|| ===================================================");
String[][] list = new String[100][3];
printWelcomeScreen();
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job extracting method


public class Contacts0 {

public static final int MAX_ENTITIES = 100;
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you come up with a better name other than max entities?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant