Skip to content

Update code to improve readability #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CT9ARyan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update code to improve readability #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae5ebed
Improve Contacts0
CT9ARyan Aug 30, 2024
04a14f2
Use Text-UI Testing
CT9ARyan Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Contacts.iml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?xml version="1.0" encoding="UTF-8"?>
<module type="JAVA_MODULE" version="4">
<component name="NewModuleRootManager" inherit-compiler-output="true">
<exclude-output />
<content url="file://$MODULE_DIR$">
<sourceFolder url="file://$MODULE_DIR$/src/main/java" isTestSource="false" />
</content>
<orderEntry type="inheritedJdk" />
<orderEntry type="sourceFolder" forTests="false" />
</component>
</module>
19 changes: 13 additions & 6 deletions src/main/java/Contacts0.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,13 @@

public class Contacts0 {

public static final int MAX_ENTITIES = 100;
Copy link
Copy Markdown
Author

@CT9ARyan CT9ARyan Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you come up with a better name other than max entities?

public static final int NUM_OF_FIELDS = 3;
Copy link
Copy Markdown
Author

@CT9ARyan CT9ARyan Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job extracting constants


public static void main(String[] args) {
final Scanner SCANNER = new Scanner(System.in);
System.out.println("|| ===================================================");
System.out.println("|| ===================================================");
System.out.println("|| Contacts - Version 0.0");
System.out.println("|| Welcome to Contacts!");
System.out.println("|| ===================================================");
String[][] list = new String[100][3];
printWelcomeScreen();
Copy link
Copy Markdown
Author

@CT9ARyan CT9ARyan Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job extracting method

String[][] list = new String[MAX_ENTITIES][NUM_OF_FIELDS];
int count = 0;
while (true) {
System.out.print("|| " + "Enter command: ");
Expand Down Expand Up @@ -146,4 +145,12 @@ public static void main(String[] args) {
}
}

private static void printWelcomeScreen() {
System.out.println("|| ===================================================");
System.out.println("|| ===================================================");
System.out.println("|| Contacts - Version 1.0.0");
System.out.println("|| Welcome to Contacts!");
System.out.println("|| ===================================================");
}

}
2 changes: 1 addition & 1 deletion textui-test/EXPECTED.TXT
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
|| ===================================================
|| ===================================================
|| Contacts - Version 0.0
|| Contacts - Version 1.0.0
|| Welcome to Contacts!
|| ===================================================
|| Enter command: || [Command entered:help]
Expand Down