Feature Noise XKpsk3 integration #4360
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2024
octol
reviewed
Feb 5, 2024
Contributor
octol
left a comment
octol
left a comment
There was a problem hiding this comment.
Having NoiseInformation separate from HostInformation, I take it this is for backwards compatibility? Or perhaps another reason?
Also, the Option, it seems like it's never None?
octol
approved these changes
Feb 5, 2024
Contributor
Author
Yes. Backwards compatibility and temporary information for the upgrade transition
It's None for mix nodes, so the description can be unified with gateways |
1 task
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
simonwicky
changed the title
Contributor
Author
|
PR stack has been collapsed |
1 task
* add custom mixnet option for gateways * add custom mixnet option for mixnode * change topology construction as to not miss described_nodes * adapt localnet scripts to new topology * add snake_case alias to described_nodes
Contributor
|
noise is dead. long live the noise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the base of stacked PRs to integrate XKpsk3 Noise connection between nym nodes
This PR concerns self-described API and Nym-API changes.
The stack of PR is as follow :
#4360 (this one) -> #4361 -> #4373 -> #4362
Checklist:
CHANGELOG.mdThis change is