Skip to content

NS Agent auth with NS API #5127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dynco-nym merged 9 commits into from
Nov 21, 2024
Merged

NS Agent auth with NS API #5127

dynco-nym merged 9 commits into from
Nov 21, 2024

Conversation

@dynco-nym
Copy link
Contributor

@dynco-nym dynco-nym commented Nov 13, 2024 •
edited
Loading

  • NS Agent authenticates with key that was registered with NS API
  • added flag to Agent to generate keypairs
  • agent requests are signed by agent
  • server-side requests are checked for authentication

This change is Reviewable

@dynco-nym dynco-nym added this to the Magura milestone Nov 13, 2024
@dynco-nym dynco-nym requested review from jstuczyn and octol November 13, 2024 11:07
@vercel
Copy link

vercel bot commented Nov 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-nextra ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 11:21pm
nym-explorer ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 11:21pm
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 11:21pm

@dynco-nym dynco-nym force-pushed the dz-agent-auth branch 3 times, most recently from 659e1a0 to ac0e840 Compare November 13, 2024 15:14
jstuczyn
jstuczyn requested changes Nov 13, 2024
View reviewed changes
@benedettadavico benedettadavico changed the base branch from release/2024.13-magura to develop November 18, 2024 11:47
@benedettadavico benedettadavico modified the milestones: Magura, Crunch Nov 18, 2024
@dynco-nym
Agents authenticate with NSAPI
ff53cd6
@dynco-nym
/submit with better auth
f5ab647 
- also adjust agent run script to authenticate, even in parallel
@dynco-nym
/request better authentication
e4df641 
- moved agent API calls to Client struct
@dynco-nym
Replay protection
1b52856
@dynco-nym
Fix testrun cleanup bug
65f4c08 
- introduce a new column last_assigned which is different than
  created_at so that stale testruns get cleaned up based on
  last_assigned
- created_at is still useful for determining the "oldest" testrun
  to be picked up
@dynco-nym dynco-nym requested a review from jstuczyn November 20, 2024 14:49
jstuczyn
jstuczyn approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@jstuczyn jstuczyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@dynco-nym
All agents use the same key
d474a28 
- remove assigned_agent column
- remove logic which would stop agents with
  the same key to connect
- as a safety measure, add cap to total no. of agents
@dynco-nym dynco-nym merged commit 3f072e4 into develop Nov 21, 2024
14 of 15 checks passed
@dynco-nym dynco-nym deleted the dz-agent-auth branch November 21, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jstuczyn jstuczyn jstuczyn approved these changes

@octol octol Awaiting requested review from octol

@durch durch Awaiting requested review from durch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Crunch

Development

Successfully merging this pull request may close these issues.

4 participants

@dynco-nym @jstuczyn @benedettadavico