-
Notifications
You must be signed in to change notification settings - Fork 265
NS Agent auth with NS API #5127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ff53cd6
Agents authenticate with NSAPI
dynco-nym f5ab647
/submit with better auth
dynco-nym e4df641
/request better authentication
dynco-nym 1b52856
Replay protection
dynco-nym 65f4c08
Fix testrun cleanup bug
dynco-nym 03f40a9
Uniform request authentication
dynco-nym 6c4333a
Suppress ts-rs serde warnings
dynco-nym bacf686
Update cargo version
dynco-nym d474a28
All agents use the same key
dynco-nym File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,101 @@ | ||
| use nym_crypto::asymmetric::ed25519::{PublicKey, Signature, SignatureError}; | ||
| use serde::{Deserialize, Serialize}; | ||
|
|
||
| pub mod get_testrun { | ||
| use super::*; | ||
| #[derive(Debug, Clone, Deserialize, Serialize)] | ||
| pub struct Payload { | ||
| pub agent_public_key: PublicKey, | ||
| pub timestamp: i64, | ||
| } | ||
|
|
||
| #[derive(Debug, Clone, Deserialize, Serialize)] | ||
| pub struct GetTestrunRequest { | ||
| pub payload: Payload, | ||
| pub signature: Signature, | ||
| } | ||
|
|
||
| impl SignedRequest for GetTestrunRequest { | ||
| type Payload = Payload; | ||
|
|
||
| fn public_key(&self) -> &PublicKey { | ||
| &self.payload.agent_public_key | ||
| } | ||
|
|
||
| fn signature(&self) -> &Signature { | ||
| &self.signature | ||
| } | ||
|
|
||
| fn payload(&self) -> &Self::Payload { | ||
| &self.payload | ||
| } | ||
| } | ||
| } | ||
|
|
||
| #[derive(Debug, Clone, Deserialize, Serialize)] | ||
| pub struct TestrunAssignment { | ||
| pub testrun_id: i64, | ||
| pub assigned_at_utc: i64, | ||
| pub gateway_identity_key: String, | ||
| } | ||
|
|
||
| pub mod submit_results { | ||
| use super::*; | ||
| #[derive(Debug, Clone, Deserialize, Serialize)] | ||
| pub struct Payload { | ||
| pub probe_result: String, | ||
| pub agent_public_key: PublicKey, | ||
| pub assigned_at_utc: i64, | ||
| } | ||
|
|
||
| #[derive(Debug, Clone, Deserialize, Serialize)] | ||
| pub struct SubmitResults { | ||
| pub payload: Payload, | ||
| pub signature: Signature, | ||
| } | ||
|
|
||
| impl SignedRequest for SubmitResults { | ||
| type Payload = Payload; | ||
|
|
||
| fn public_key(&self) -> &PublicKey { | ||
| &self.payload.agent_public_key | ||
| } | ||
|
|
||
| fn signature(&self) -> &Signature { | ||
| &self.signature | ||
| } | ||
|
|
||
| fn payload(&self) -> &Self::Payload { | ||
| &self.payload | ||
| } | ||
| } | ||
| } | ||
|
|
||
| pub trait SignedRequest { | ||
| type Payload: serde::Serialize; | ||
|
|
||
| fn public_key(&self) -> &PublicKey; | ||
| fn signature(&self) -> &Signature; | ||
| fn payload(&self) -> &Self::Payload; | ||
| } | ||
|
|
||
| pub trait VerifiableRequest: SignedRequest { | ||
| type Error: From<bincode::Error> + From<SignatureError>; | ||
|
|
||
| fn verify_signature(&self) -> Result<(), Self::Error> { | ||
| bincode::serialize(self.payload()) | ||
| .map_err(Self::Error::from) | ||
| .and_then(|serialized| { | ||
| self.public_key() | ||
| .verify(serialized, self.signature()) | ||
| .map_err(Self::Error::from) | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| impl<T> VerifiableRequest for T | ||
| where | ||
| T: SignedRequest, | ||
| { | ||
| type Error = anyhow::Error; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| nym-gateway-probe | ||
| keys/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #!/bin/bash | ||
|
|
||
| mkdir -p keys | ||
| cargo run --package nym-node-status-agent -- generate-keypair --path keys/private |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.