inspector completion: fix inaccessible db silent err #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, running `leapp-inspector --db ~/Downloads/leapp.db actors --actor` and pressing Tab did not do anything. It was because the bash completion script exited silently when it concluded that the ~/Downloads/leapp.db is inaccessible. With this fix one gets this error instead: ``` OSError: The ~/Downloads/leapp.db file doesn't exist. Specify the correct path to the leapp database file. ``` With that the user gets a hint that they need to pass a path like /home/user/Downloads/leapp.db to get the completion working. Assisted-by: Cursor AI with Claude Sonnet 4
pirat89
requested changes
Sep 6, 2025
| for word in "${COMP_WORDS[@]}"; do | ||
| if [[ "$use_next" == "1" ]]; then | ||
| [[ -e "$word" ]] || return 1 | ||
| # Check if file exists, but still return the path |
There was a problem hiding this comment.
actually it means that function is behaving differently in comparison to the description and expactations. also you can see that script is failing on python error as it's failing on the leapp-inspector script execution. The clean solution would be just adding a log error instead.
Similarly in the other case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, running
leapp-inspector --db ~/Downloads/leapp.db actors --actorand pressing Tab did not do anything. It was because the bash completion script exited silently when it concluded that the ~/Downloads/leapp.db is inaccessible.With this fix one gets this error instead:
With that the user gets a hint that they need to pass a path like /home/user/Downloads/leapp.db to get the completion working.
Assisted-by: Cursor AI with Claude Sonnet 4