Skip to content

inspector completion: fix inaccessible db silent err #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

inspector completion: fix inaccessible db silent err #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/leappinspector/completion/leapp-inspector.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ _get_dbfile() {
local use_next=0
for word in "${COMP_WORDS[@]}"; do
if [[ "$use_next" == "1" ]]; then
[[ -e "$word" ]] || return 1
# Check if file exists, but still return the path
Copy link
Member

@pirat89 pirat89 Sep 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually it means that function is behaving differently in comparison to the description and expactations. also you can see that script is failing on python error as it's failing on the leapp-inspector script execution. The clean solution would be just adding a log error instead.

Similarly in the other case.

echo "$word"
return 0
fi
Expand All @@ -40,7 +40,7 @@ _get_context() {
local use_next=0
for word in "${COMP_WORDS[@]}"; do
if [[ "$use_next" == "1" ]]; then
[[ -e "$word" ]] || return 1
# Check if file exists, but still return the path
echo "$word"
return 0
fi
Expand Down