Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added L4 IT MOp #1011

Closed
wants to merge 3 commits into from
Closed

Added L4 IT MOp #1011

wants to merge 3 commits into from

Conversation

shawntanzk
Copy link
Contributor

Fixes #884

  • Requires some input on what goes in/stays out, see ticket [NTR]L4 IT (Mus MOp) #884 for details.
  • Not sure if morphological description is useful in this case too (given diverse morphologies)

@shawntanzk
Added L4 IT MOp
8761b60 
Fixes #884
- Requires some input on what goes in/stays out, see ticket #884 for details.
- Not sure if morphological description is useful in this case too (given diverse morphologies)
dosumis
dosumis requested changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@dosumis dosumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold off merging until further discussion (please see comment)

src/ontology/cl-edit.owl

AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:33184512") obo:IAO_0000115 obo:CL_4023051 "An intratelencephalic-projecting glutamatergic neuron that is located in the boundary between L2/3 and L5 of the primary motor cortex. These cells have diverse morphologies with some pyramidal and some stellate cells.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This strikes me as a heterogenous grouping class that only makes sense in the context of single cell transcriptomics clustering. I wonder whether we should make that explicit + define using markers (RF markers could work well for this). I think worth holding off for further discussion.

@shawntanzk shawntanzk self-assigned this Jun 7, 2021
@shawntanzk
Copy link
Contributor Author

migrated to obophenotype/brain_data_standards_ontologies#226

@shawntanzk shawntanzk closed this Dec 9, 2021
@shawntanzk shawntanzk deleted the L4-IT-MOp-(Mus) branch December 9, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dosumis dosumis dosumis requested changes

@patrick-lloyd-ray patrick-lloyd-ray patrick-lloyd-ray approved these changes

@tgbugs tgbugs Awaiting requested review from tgbugs

Assignees

@shawntanzk shawntanzk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NTR]L4 IT (Mus MOp)
3 participants
@shawntanzk @dosumis @patrick-lloyd-ray