refactor: Convert to template function

oboukli · Sep 5, 2023 · 832eb84 · 832eb84
1 parent 43de941
commit 832eb84
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/benchmark/palindromic_number_benchmark.cpp b/benchmark/palindromic_number_benchmark.cpp
@@ -25,7 +25,8 @@ TEST_CASE(
         .title("Palindromic number")
 
         .run(
-            NAMEOF_RAW(forfun::palindromic_number::fast::is_palindrome).c_str(),
+            NAMEOF_RAW(forfun::palindromic_number::fast::is_palindrome<int>)
+                .c_str(),
             []() {
                 auto r{forfun::palindromic_number::fast::is_palindrome(p)};
                 ankerl::nanobench::doNotOptimizeAway(r);

diff --git a/include/forfun/palindromic_number.hpp b/include/forfun/palindromic_number.hpp
@@ -10,16 +10,20 @@
 #ifndef FORFUN_PALINDROMIC_NUMBER_HPP_
 #define FORFUN_PALINDROMIC_NUMBER_HPP_
 
+#include <concepts>
+
 namespace forfun::palindromic_number {
 
 namespace fast {
 
-[[nodiscard]] constexpr bool is_palindrome(int const n) noexcept {
-    int nn{0};
-    int d{n};
-    while (d > 0) {
-        nn = (nn * 10) + d % 10;
-        d /= 10;
+template <typename T>
+    requires std::integral<T>
+[[nodiscard]] constexpr bool is_palindrome(T const n) noexcept {
+    T nn{};
+    auto d{n};
+    while (d > T{0}) {
+        nn = (nn * T{10}) + d % T{10};
+        d /= T{10};
     }
 
     return n == nn;

diff --git a/test/palindromic_number_test.cpp b/test/palindromic_number_test.cpp
@@ -12,7 +12,7 @@
 
 TEMPLATE_TEST_CASE_SIG(
     "palindromic_number", "", ((auto sut), sut),
-    (forfun::palindromic_number::fast::is_palindrome),
+    (forfun::palindromic_number::fast::is_palindrome<int>),
     (forfun::palindromic_number::stl::is_palindrome)) {
     SECTION("Palindromic numbers") {
         GIVEN("a palindromic number") {