Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trailing slash in url #760

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Fix trailing slash in url #760

merged 1 commit into from
Feb 17, 2023

Conversation

maiste
Copy link
Member

@maiste maiste commented Feb 16, 2023

This is an attempt to fix the problem mentioned here: #607 (comment).

The solution comes from @cuihtlauac at ocaml/ocaml.org#866.

@maiste maiste added type/bug Something isn't working context/causing-pain Limitations of ocaml-ci which hurt development workflows labels Feb 16, 2023
@cuihtlauac
Copy link

Let me know if it solves your problem, I'm curious

@maiste
Copy link
Member Author

maiste commented Feb 16, 2023 •
edited
Loading

Sure, no problem! On my workstation tests, it fixed the problem. Thanks for the solution 👍

benmandrew
benmandrew approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@benmandrew benmandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my end 👍

@maiste
Copy link
Member Author

maiste commented Feb 17, 2023 •
edited
Loading

Let's try in production, then! :)

It's deploy here: https://ci.ocamllabs.io/
It seems to work for now.

@maiste maiste merged commit 5994f88 into ocurrent:master Feb 17, 2023
@maiste maiste deleted the bug/trailing-slash branch February 17, 2023 14:30
@cuihtlauac cuihtlauac mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmandrew benmandrew benmandrew approved these changes

@tmcgilchrist tmcgilchrist Awaiting requested review from tmcgilchrist

Assignees
No one assigned
Labels
context/causing-pain Limitations of ocaml-ci which hurt development workflows type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maiste @cuihtlauac @benmandrew