Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Pytorch image changes for ppc64le #3

Closed

Conversation

bhagyashrigai
Copy link

No description provided.

Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
@@ -14,6 +14,9 @@ LABEL name="odh-notebook-jupyter-pytorch-ubi9-python-3.9" \
# Install Python packages and Jupyterlab extensions from Pipfile.lock
COPY Pipfile.lock ./

# Switch to root user
USER root
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any specific reason for switching to root here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a permission issue when attempting to write the pipfile.lock file to the container image. [Error:-Failed to write lockfile to container image: [Errno 13] Permission denied: 'Pipfile.lock']
hence above changes were done.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets debug that instead of making root context here, use podman.. or check if you are facing any selinux related issue etc..

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkumatag @npanpaliya
I haven't found any other error in the logs besides this 'permission denied'( [Error:-Failed to write lockfile to container image: [Errno 13] Permission denied: 'Pipfile.lock']) while building the image.
Instead of using the root user, can we use then:-
COPY --chown=1001:0 Pipfile.lock ./
Could you please guide me further on that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my point is if this docker file is built on x86 then same file should on ppc64le as well, I don't see a point in modifying just for power!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this because of the different base image? 🤔 if yes - lets fix the base image accordingly..

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this is because of using a non root user.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkumatag @npanpaliya

  1. After updating the notebook repository to the latest tag v1.20.0, I have successfully built the PyTorch image.
    No root user changes are required inside this Dockerfile. All packages installed successfully into the container.
    Snap:-
powercommand_snap
  1. Additionally, I tested the base image building on an x86 VM. It was observed that the build encounters the same error "failed to write lockfile to container image." However, this error does not impact any functionality and can be safely ignored.

Snap:-
x86_baseimage

  1. I need to close this PR because the base branch has been updated with the latest changes. I will create a new PR for this pytorch and datascience image builds changes."

jupyter/pytorch/ubi9-python-3.9/Pipfile Outdated Show resolved Hide resolved
@@ -14,6 +14,9 @@ LABEL name="odh-notebook-jupyter-pytorch-ubi9-python-3.9" \
# Install Python packages and Jupyterlab extensions from Pipfile.lock
COPY Pipfile.lock ./

# Switch to root user
USER root
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets debug that instead of making root context here, use podman.. or check if you are facing any selinux related issue etc..

@bhagyashrigai bhagyashrigai changed the base branch from latest-ppc64le-20may to latest-ppc64le July 17, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants