Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Pytorch image changes for ppc64le #3
Updated Pytorch image changes for ppc64le #3
Changes from 3 commits
2a8404a
1f57851
4a529fc
3bbd4ea
e2a3fef
861089b
f4a6161
6e22a62
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any specific reason for switching to root here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a permission issue when attempting to write the pipfile.lock file to the container image. [Error:-Failed to write lockfile to container image: [Errno 13] Permission denied: 'Pipfile.lock']
hence above changes were done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets debug that instead of making root context here, use podman.. or check if you are facing any selinux related issue etc..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkumatag @npanpaliya
I haven't found any other error in the logs besides this 'permission denied'( [Error:-Failed to write lockfile to container image: [Errno 13] Permission denied: 'Pipfile.lock']) while building the image.
Instead of using the root user, can we use then:-
COPY --chown=1001:0 Pipfile.lock ./
Could you please guide me further on that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my point is if this docker file is built on x86 then same file should on ppc64le as well, I don't see a point in modifying just for power!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this because of the different base image? 🤔 if yes - lets fix the base image accordingly..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably this is because of using a non root user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkumatag @npanpaliya
No root user changes are required inside this Dockerfile. All packages installed successfully into the container.
Snap:-
Snap:-