Skip to content

Conversation

@will-moore
Copy link
Member

@will-moore will-moore commented Aug 11, 2025

Fixes #445.

We no-longer need to create a new store since #413 the store is the same for all subclasses of ome_zarr.format.Format.

Just 1 test failed test_astronaut_download() and this was fixed by download() using the detected zarr_format for writing.

This is potentially quite a big change (hence the Draft status) - Need to consider if that test failure should be fixed in a better way etc.
Do we need the Format class hierarchy any more? Is there a better way to handle format differences?

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.54%. Comparing base (2eec589) to head (948c6a0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #468      +/-   ##
==========================================
- Coverage   86.99%   86.54%   -0.46%     
==========================================
  Files          13       13              
  Lines        1769     1761       -8     
==========================================
- Hits         1539     1524      -15     
- Misses        230      237       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@will-moore will-moore marked this pull request as draft August 12, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Store can lose storage_options in version detection logic

1 participant