Remove detected.init_store() in Location.__init__ #468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #445.
We no-longer need to create a new
storesince #413 the store is the same for all subclasses ofome_zarr.format.Format.Just 1 test failed
test_astronaut_download()and this was fixed bydownload()using the detected zarr_format for writing.This is potentially quite a big change (hence the Draft status) - Need to consider if that test failure should be fixed in a better way etc.
Do we need the Format class hierarchy any more? Is there a better way to handle format differences?