Update to AndroidX, gradle version and plugin updates #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekigamba
force-pushed
the
update-dependencies
branch
5 times, most recently
from
5559d3d to
0845b02
Compare
…a 11 - Fix getMasterCommitCount() groovy function not working by fetching origin and changing branch to origin/master
ekigamba
force-pushed
the
update-dependencies
branch
from
0845b02 to
db7770e
Compare
ekigamba
force-pushed
the
update-dependencies
branch
from
95ecda9 to
89b3374
Compare
ekigamba
force-pushed
the
update-dependencies
branch
from
a353b1b to
a1ca3cc
Compare
ekigamba
force-pushed
the
update-dependencies
branch
2 times, most recently
from
0406944 to
89c8389
Compare
- A bug as reported on a relative repository vanniktech/gradle-android-junit-jacoco-plugin#183 prevents jacoco exec coverage file from being generated when android.buildTypes.debug.testCoverageEnabled is true - Disabled the createDebugCoverageReport from the jacocoTestReport therefore disabling running of instrumentation tests
ekigamba
force-pushed
the
update-dependencies
branch
from
89c8389 to
1530439
Compare
Pull Request Test Coverage Report for Build #584
💛 - Coveralls |
ekigamba
force-pushed
the
update-dependencies
branch
from
e89de85 to
3e9e3c2
Compare
ekigamba
force-pushed
the
update-dependencies
branch
from
3e9e3c2 to
db2a14b
Compare
7 tasks
ekigamba
force-pushed
the
update-dependencies
branch
2 times, most recently
from
db184bb to
6d69618
Compare
ekigamba
force-pushed
the
update-dependencies
branch
from
6d69618 to
8335276
Compare
- Downgrade Robolectric to 4.3.1 which is the only working version currently - Update Mapbox annotations to com.mapbox.mapboxsdk:mapbox-android-plugin-annotation-v9:0.9.0 - Move dependency names and versions to configs.gradle - Switch CI OS to Macos for better AVD stability - Enable download of Robolectric jars manually
ekigamba
force-pushed
the
update-dependencies
branch
from
0460b35 to
b22a1ed
Compare
|
The PR looks good for merge, however I think we should create a ticket around reporting the Instrumentation coverage. |
| @@ -29,6 +29,11 @@ POM_SETTING_LICENCE_URL=http://www.apache.org/licenses/LICENSE-2.0.txt | |||
| POM_SETTING_LICENCE_DIST=repo | |||
There was a problem hiding this comment.
Don't we need to bump up the artefact version for tagging on git and publishing the snapshot?
There was a problem hiding this comment.
Yes, we can do that here but I prefer to have this on separate PRs for better tracking since releases were not always done after every PR https://github.com/onaio/kujaku/pulls?q=is%3Apr+sort%3Aupdated-desc+is%3Aclosed+release
Comment on lines
+66
to
+67
| //libraryModuleRelease(configuration) | ||
| libraryModuleDevelopment(this, configuration) |
There was a problem hiding this comment.
We need some documentation on the usage of these i.e. release vs dev mode e.g. on the READ ME
There was a problem hiding this comment.
An issue to update the documentation here #359
ndegwamartin
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced coverage by 10%
buildType.debug.testCoverageEnabledis set totrue. With this option set to false, gradle does not find the task'createDebugCoverageReportwhich is used to run instrumentation tests with coverage reporting. These tests contribute to a fraction of the test coverage.Below is the difference especially in the
samplemodule where the tests are mostly instrumentation testsBefore
After
This is being tracked here