Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update library to support latest dependencies #207

Merged
merged 35 commits into from
Mar 14, 2023

Conversation

MaxStalker
Copy link
Collaborator

Work in progress for #205

Description

  • Bumped packages to latest versions
  • Fixed regular expression used to catch log messages
  • Emulator dependent tests reintroduced to be able to run on CI
  • Updated CI workflows to run latest version of Flow CLI and only on appropriate events
  • Add test coverage report
  • Add dependecy testbed report

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@MaxStalker MaxStalker requested a review from a team as a code owner March 10, 2023 09:54
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2023

🦋 Changeset detected

Latest commit: eb31579

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@onflow/flow-js-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Dependency Testbed

  • Flow CLI: 0.46.2
  • FCL: ^1.3.2

Release Version

The package containing these changes will be released with version 0.3.1

@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
92.69% (+62.47% 🔼)
545/588
🟡 Branches
76.89% (+67.4% 🔼)
163/212
🟢 Functions
93.04% (+75.36% 🔼)
107/115
🟢 Lines
93.2% (+62.44% 🔼)
521/559

Test suite run success

100 tests passing in 13 suites.

Report generated by 🧪jest coverage report action from eb31579

Copy link

@bthaile bthaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build and tests run, there are a lot of circular deps, but appear to be existing.

@MaxStalker
Copy link
Collaborator Author

build and tests run, there are a lot of circular deps, but appear to be existing.

Circular dependecies need to be unwinded, indeed 😅
Will make an issue and prepare refactoring after everything else is crossed out on the checklist.

@MaxStalker MaxStalker merged commit a65ff32 into master Mar 14, 2023
@MaxStalker MaxStalker deleted the max/grant-latest-version branch March 14, 2023 23:30
This was referenced Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants