-
Notifications
You must be signed in to change notification settings - Fork 218
Update GraphRAG dataprep and retriever components #1746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… key Signed-off-by: Ed Lee <[email protected]>
Signed-off-by: Ed Lee <[email protected]>
openai like endpoints with key TGI_LLM_ENDPOINT_KEY Signed-off-by: Ed Lee <[email protected]>
…onent. The latest openai does not have ResponseTextAnnotationDeltaEvent required by these components and so pinned openai==1.66.3 Signed-off-by: Ed Lee <[email protected]>
… limits. dont need to use hugging face tokenizer to trim messages Signed-off-by: Ed Lee <[email protected]>
|
@aMahanna any ideas about arango retriever failed test? I can reproduce it when running locally, I tried pinning some package versions but still same error. it's a 500 code seems ingestion issue.. dataprep ingestion was fine. thanks! |
Strange...Looks like an env var issue. Graph Name seems to be empty here, even though it has a default if no env var is provided: https://github.com/opea-project/GenAIComps/blob/main/comps/retrievers/src/integrations/config.py#L203 In any case this PR has no direct relation to ArangoDB, so feel free to proceed with merging while I investigate this |
|
Thank you @aMahanna! |
ashahba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ens for when a hf tokenizer is available or not available Signed-off-by: Ed Lee <[email protected]>
for more information, see https://pre-commit.ci
rbrugaro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing back the HF tokenizer trimming method and addressing the case when that's not available. Once tests pass is good to merge
Signed-off-by: Ed Lee <[email protected]>
…to graphrag_workshop
for more information, see https://pre-commit.ci
Signed-off-by: Ed Lee <[email protected]>
…to graphrag_workshop
for more information, see https://pre-commit.ci
Description
from llama_index.llms.openai import OpenAIfailed with unpinned packages. llama index required the ResponseTextAnnotationDeltaEvent and was no longer available in openai>1.66.3.Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.