update: OpeaArangoRetriever & OpeaArangoDataprep #1764

aMahanna · 2025-05-30T18:43:07Z

Description

Updating OpeaArangoRetriever to investigate failure observed here: #1746 (comment)

Also fixing OpeaArangoDataprep based on input processing fixes in OpeaArangoRetriever

Also introduces ARANGO_SEARCH_TYPE as an environment variable to offer selection between Vector & Hybrid search.

Issues

N/A

Type of change

List the type of change like below. Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would break existing design and interface)
Others (enhancement, documentation, validation, etc.)

Dependencies

Locks langchain-arangodb to 0.0.6

codecov · 2025-05-30T18:46:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines	Coverage Δ
comps/cores/proto/api_protocol.py	`92.05% <100.00%> (+0.01%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

aMahanna · 2025-06-02T16:51:14Z

@rbrugaro FYI The ArangoDB Retriever test is passing, any idea on how I can fix the "Service X did not come up in time" error?

rbrugaro · 2025-06-02T17:08:27Z

@aMahanna great that the ArangoDB retriever is passing and thanks for looking into it so promptly!. The timing issue seems like a CI side effect, I manually triggered one and passed. lets update your branch with main and if there are still tests with timing issues I can trigger those manually and we can get it merged.

Signed-off-by: Anthony Mahanna <[email protected]>

for more information, see https://pre-commit.ci Signed-off-by: Anthony Mahanna <[email protected]>

Signed-off-by: Anthony Mahanna <[email protected]>

…ct#1766) Signed-off-by: Mustafa <[email protected]> Signed-off-by: Anthony Mahanna <[email protected]>

aMahanna · 2025-06-02T17:22:52Z

@aMahanna great that the ArangoDB retriever is passing and thanks for looking into it so promptly!. The timing issue seems like a CI side effect, I manually triggered one and passed. lets update your branch with main and if there are still tests with timing issues I can trigger those manually and we can get it merged.

@rbrugaro sounds good thanks! Just rebased to pass DCO

rbrugaro

LGTM!

ashahba

LGTM!

* update: OpeaArangoRetriever Signed-off-by: Anthony Mahanna <[email protected]> * lock: `langchain-arangodb` Signed-off-by: Anthony Mahanna <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: Anthony Mahanna <[email protected]> * fix: `test_retrievers_arango.sh` Signed-off-by: Anthony Mahanna <[email protected]> * attempt: `graph_name` Signed-off-by: Anthony Mahanna <[email protected]> * attempt fix: query Signed-off-by: Anthony Mahanna <[email protected]> * fix: hasattr Signed-off-by: Anthony Mahanna <[email protected]> * fix: getattr Signed-off-by: Anthony Mahanna <[email protected]> * exclude_none Signed-off-by: Anthony Mahanna <[email protected]> * bump Signed-off-by: Anthony Mahanna <[email protected]> * increase sleep Signed-off-by: Anthony Mahanna <[email protected]> * fix the redis version due to conflic with langchain-redis (opea-project#1766) Signed-off-by: Mustafa <[email protected]> Signed-off-by: Anthony Mahanna <[email protected]> --------- Signed-off-by: Anthony Mahanna <[email protected]> Signed-off-by: Mustafa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mustafa <[email protected]> Signed-off-by: Anthony Mahanna <[email protected]>

* update: OpeaArangoRetriever & OpeaArangoDataprep (#1764) * update: OpeaArangoRetriever Signed-off-by: Anthony Mahanna <[email protected]> * lock: `langchain-arangodb` Signed-off-by: Anthony Mahanna <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: Anthony Mahanna <[email protected]> * fix: `test_retrievers_arango.sh` Signed-off-by: Anthony Mahanna <[email protected]> * attempt: `graph_name` Signed-off-by: Anthony Mahanna <[email protected]> * attempt fix: query Signed-off-by: Anthony Mahanna <[email protected]> * fix: hasattr Signed-off-by: Anthony Mahanna <[email protected]> * fix: getattr Signed-off-by: Anthony Mahanna <[email protected]> * exclude_none Signed-off-by: Anthony Mahanna <[email protected]> * bump Signed-off-by: Anthony Mahanna <[email protected]> * increase sleep Signed-off-by: Anthony Mahanna <[email protected]> * fix the redis version due to conflic with langchain-redis (#1766) Signed-off-by: Mustafa <[email protected]> Signed-off-by: Anthony Mahanna <[email protected]> --------- Signed-off-by: Anthony Mahanna <[email protected]> Signed-off-by: Mustafa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mustafa <[email protected]> Signed-off-by: Anthony Mahanna <[email protected]> * fix: `ARANGO_SEARCH_MODE` Signed-off-by: Anthony Mahanna <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: readme Signed-off-by: Anthony Mahanna <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Anthony Mahanna <[email protected]> Signed-off-by: Mustafa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mustafa <[email protected]>

aMahanna requested review from Spycsh, XinyuYe-Intel, ftian1, letonghan, lkk12014402, lvliang-intel and minmin-intel as code owners May 30, 2025 18:43

aMahanna mentioned this pull request May 30, 2025

Update GraphRAG dataprep and retriever components #1746

Merged

4 tasks

aMahanna requested review from chensuyue and rbrugaro as code owners May 30, 2025 19:33

aMahanna changed the title ~~update: OpeaArangoRetriever~~ update: OpeaArangoRetriever & OpeaArangoDataprep May 30, 2025

aMahanna and others added 12 commits June 2, 2025 13:21

update: OpeaArangoRetriever

830ce04

Signed-off-by: Anthony Mahanna <[email protected]>

lock: langchain-arangodb

58b5588

Signed-off-by: Anthony Mahanna <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

cbc65b7

for more information, see https://pre-commit.ci Signed-off-by: Anthony Mahanna <[email protected]>

fix: test_retrievers_arango.sh

a53a81f

Signed-off-by: Anthony Mahanna <[email protected]>

attempt: graph_name

1665794

Signed-off-by: Anthony Mahanna <[email protected]>

attempt fix: query

7e16aa7

Signed-off-by: Anthony Mahanna <[email protected]>

fix: hasattr

6a07948

Signed-off-by: Anthony Mahanna <[email protected]>

fix: getattr

cbbdc85

Signed-off-by: Anthony Mahanna <[email protected]>

exclude_none

a9a8bba

Signed-off-by: Anthony Mahanna <[email protected]>

bump

67c3e4f

Signed-off-by: Anthony Mahanna <[email protected]>

increase sleep

642892b

Signed-off-by: Anthony Mahanna <[email protected]>

fix the redis version due to conflic with langchain-redis (opea-proje…

7eebe28

…ct#1766) Signed-off-by: Mustafa <[email protected]> Signed-off-by: Anthony Mahanna <[email protected]>

aMahanna force-pushed the fix-arango-retriever branch from f9c8df9 to 7eebe28 Compare June 2, 2025 17:21

Merge branch 'main' into fix-arango-retriever

ec00e51

rbrugaro approved these changes Jun 2, 2025

View reviewed changes

ashahba approved these changes Jun 2, 2025

View reviewed changes

ashahba merged commit bf1121e into opea-project:main Jun 2, 2025
43 of 46 checks passed

aMahanna deleted the fix-arango-retriever branch June 2, 2025 23:11

ZePan110 mentioned this pull request Jun 3, 2025

[Bug] retrievers_arango UT failed on Xeon #1757

Closed

9 tasks

joshuayao mentioned this pull request Jun 17, 2025

[Feature] ArangoDB for GraphRAG in v1.4 opea-project/GenAIExamples#1438

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

update: OpeaArangoRetriever & OpeaArangoDataprep #1764

update: OpeaArangoRetriever & OpeaArangoDataprep #1764

Uh oh!

aMahanna commented May 30, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 30, 2025 •

edited

Loading

Uh oh!

aMahanna commented Jun 2, 2025

Uh oh!

rbrugaro commented Jun 2, 2025

Uh oh!

aMahanna commented Jun 2, 2025

Uh oh!

rbrugaro left a comment

Uh oh!

ashahba left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

update: OpeaArangoRetriever & OpeaArangoDataprep #1764

update: OpeaArangoRetriever & OpeaArangoDataprep #1764

Uh oh!

Conversation

aMahanna commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues

Type of change

Dependencies

Uh oh!

codecov bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aMahanna commented Jun 2, 2025

Uh oh!

rbrugaro commented Jun 2, 2025

Uh oh!

aMahanna commented Jun 2, 2025

Uh oh!

rbrugaro left a comment

Choose a reason for hiding this comment

Uh oh!

ashahba left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aMahanna commented May 30, 2025 •

edited

Loading

codecov bot commented May 30, 2025 •

edited

Loading