-
Notifications
You must be signed in to change notification settings - Fork 218
Apply uv tool for dependency version control #1789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6295b9e to
aee7c1b
Compare
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: chensuyue <[email protected]>
2. Separate gpu and cpu requirements.txt Signed-off-by: chensuyue <[email protected]>
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: chensuyue <[email protected]>
This reverts commit b48b326 Signed-off-by: chensuyue <[email protected]>
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: chensuyue <[email protected]>
lkk12014402
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
image2image_on_intel_hpu |
|
llms_doc-summarization_vllm_on_intel_hpu |
* Fix language_detection test Signed-off-by: chensuyue <[email protected]> * Fix lvms_llama_vision test Signed-off-by: chensuyue <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: chensuyue <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
The 6 issues found in the last test round have been addressed, 4 known issues, 2 fixed in #1812, so this PR is ready for merge. https://github.com/opea-project/GenAIComps/actions/runs/15818449179 |
| RUN pip install --no-cache-dir --upgrade pip setuptools uv && \ | ||
| $uvpip -r /home/user/comps/agent/src/requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this drops pytorch CPU version override, don't indirect deps bring it in any more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This docker image does not include torch in its dependency, so I remove this --extra-index-url.
--------- Signed-off-by: chensuyue <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Description
UV provides a drop-in replacement for common pip, pip-tools commands, deps installation experience a 10-100x speedup with the uv pip interface. https://docs.astral.sh/uv/.
For examples:
docker build -t opea/build:test -f comps/retrievers/src/Dockerfile .uv install Vs. pip install is 30.1s Vs.173.6s.
For example, transformers, langchain, huggingface_hub updated with high frequency.
requirements.txttorequirements.inas dependency template, including the first level dependencies.uv pip compilegeneraterequirements.txtorrequirements-cpu.txtandrequirements-gpu.txtfor different HW ENV. Full CMD is$ uv pip compile requirements.in --universal -o requirements.txt --upgrade,requirements.inworks as a dependency template,--universalmeans cross platform,--upgrademeans overwrite requirements.txt with latest version.CPU version CMD is
$ uv pip compile --extra-index-url https://download.pytorch.org/whl/cpu --index-strategy unsafe-best-match requirements.in --universal -o requirements-cpu.txt --upgraderequirements.inand test with CI. Module dependency version differences #1775Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.