Skip to content

Conversation

@lianhao
Copy link
Collaborator

@lianhao lianhao commented Jun 17, 2025

Description

Issues

Fixes #1800

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I wonder whether it would make more sense just to move version enforcement to asr/src/requirements.txt?

PS. There are couple of other Dockerfiles, which are using their own requirements.txt files instead of one from another component like is done here. Why the heck those do not specify proper numpy version in their requirements.txt files?

$ git grep 'numpy[=<]'
comps/animation/src/requirements.txt:numpy==1.23.5
comps/language_detection/src/requirements.txt:numpy==1.26.4
comps/llms/src/text-generation/Dockerfile.intel_hpu:    pip install --no-cache-dir --upgrade --force-reinstall pydantic numpy==1.25
comps/text2cypher/src/Dockerfile.intel_hpu:    pip install --no-cache-dir --upgrade --force-reinstall pydantic numpy==1.26.3
comps/third_parties/llama-vision/src/requirements.txt:numpy<2
comps/third_parties/llama-vision/src/requirements_tp.txt:numpy<2

(And why fixed 1.x versions are used on some other requirements.txt files, as can be seen above, instead of <2 ? Now that main numpy development is for 2.x versions, I think that would just mean getting security update versions...)

@lianhao
Copy link
Collaborator Author

lianhao commented Jun 30, 2025

This is fixed by #1789

@lianhao lianhao closed this Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] opea/speecht5-gaudi or opea/whisper-gaudi is not working

2 participants