speecht5: Support air gapped environment #1801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
lvliang-intel
approved these changes
Jun 23, 2025
eero-t
approved these changes
Jun 23, 2025
Contributor
eero-t
left a comment
eero-t
left a comment
There was a problem hiding this comment.
Approved.
PS. I wonder whether some note about the origin / copyright / license for the files like these should be also be in the final image.
(When things are installed from distro packages, distro package maintainer has taken care that the legal requirements for distributing the content have been fullfilled by the package installation. When pulling things directly from external sources, one needs to do that manually.)
These ones are from an Intel project, and seem to be under Apache-2 license. Other air-gap support PRs have pulled things also from other sources (potentially with other licenses etc).
pre-commit-ci
bot
requested review from
XinyuYe-Intel,
ftian1,
lkk12014402 and
minmin-intel
as code owners
Signed-off-by: Lianhao Lu <[email protected]>
letonghan
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.