Bugfix for follow-up query with a .png image #900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Melanie Buehler <[email protected]>
dmsuehir
approved these changes
Nov 14, 2024
Contributor
dmsuehir
left a comment
dmsuehir
left a comment
There was a problem hiding this comment.
LGTM, I tried it out with the GenAIExamples MultimodalQnA megaservice UI and it fixed the error that I was seeing earlier. Thanks!
aice-support
approved these changes
Nov 14, 2024
aice-support
left a comment
aice-support
left a comment
There was a problem hiding this comment.
the title mentions png, but understand that it is for mp4 video file. good to put some explanations for only mp4 files supported.
louie-tsai
approved these changes
Nov 14, 2024
Contributor
Author
I added comments inline. The |
madison-evans
pushed a commit
to SAPD-Intel/GenAIComps
that referenced
this pull request
May 12, 2025
* MultimodalQnA bugfix for follow-up query with a .png image Signed-off-by: Melanie Buehler <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Melanie Buehler <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Abolfazl Shahbazi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the
dataprep-multimodal-redismicroservice where non-zero time metadata was being stored for .png images. This was resulting in an exceptionValueError: invalid literal for int()being thrown and displayed in the MultimodalQnA UI during follow-up queries.Issues
Related to the Image_and_Audio_Support_in_MultimodalQnA RFC
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
N/A
Tests
N/A