Skip to content

Bugfix for follow-up query with a .png image #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
louie-tsai merged 4 commits into from
Nov 14, 2024
Merged

Bugfix for follow-up query with a .png image #900

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17e999e
MultimodalQnA bugfix for follow-up query with a .png image
mhbuehler Nov 14, 2024
5dd10f8
Merge branch 'main' into melanie/image_time_bugfix
mhbuehler Nov 14, 2024
a8b7db7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 14, 2024
f8e1576
Merge branch 'main' into melanie/image_time_bugfix
ashahba Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions comps/dataprep/multimodal/redis/langchain/multimodal_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,7 @@ def extract_frames_and_generate_captions(
# Set up location to store frames and annotations
os.makedirs(output_dir, exist_ok=True)
os.makedirs(os.path.join(output_dir, "frames"), exist_ok=True)
is_video = os.path.splitext(video_path)[-1] == ".mp4"

# Load video and get fps
vidcap = cv2.VideoCapture(video_path)
Expand Down Expand Up @@ -294,8 +295,8 @@ def extract_frames_and_generate_captions(
"video_name": os.path.basename(video_path),
"b64_img_str": b64_img_str,
"caption": text,
"time": mid_time_ms,
"frame_no": frame_no,
"time": mid_time_ms if is_video else 0.0,
"frame_no": frame_no if is_video else 0,
"sub_video_id": idx,
}
)
Expand Down
Loading