Skip to content

Conversation

@wanhakim
Copy link
Collaborator

@wanhakim wanhakim commented Aug 1, 2025

No description provided.

Copilot AI review requested due to automatic review settings August 1, 2025 09:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates sandbox run error handling and adds fixes for document summarization (docsum) and code generation (codegen) workflows. The changes improve user experience through better error handling, enhanced debugging capabilities, and fixes for specific OPEA service workflows.

  • Implements automatic namespace deletion and redeployment for sandboxes when conflicts occur
  • Adds comprehensive pod dependency analysis and improved debug logs interface
  • Fixes docsum and codegen workflow configurations and service mappings

Reviewed Changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
studio-frontend/packages/ui/src/views/debuglogs/index.jsx Adds dependencies column to pod logs table and improves modal layout
studio-frontend/packages/ui/src/views/canvas/index.jsx Handles duplicated flow type preservation for proper canvas routing
studio-frontend/packages/ui/src/views/canvas/CanvasHeader.jsx Updates duplicate flow logic to preserve original flow type
studio-frontend/packages/ui/src/ui-component/table/FlowListTable.jsx Adds automatic redeployment handling for namespace conflicts
studio-frontend/packages/ui/src/ui-component/button/FlowListMenu.jsx Updates duplicate flow logic to preserve original flow type
studio-frontend/packages/server/src/nodes/llm_codegen.js Fixes codegen service name and model configuration
studio-backend/app/utils/namespace_utils.py Implements comprehensive pod failure detection and monitoring
studio-backend/app/services/namespace_service.py Adds namespace deletion before redeployment logic
studio-backend/app/routers/debuglog_router.py Implements detailed pod dependency analysis
app-backend/megaservice.py Adds file input support and improves docsum request handling
Comments suppressed due to low confidence (1)

studio-backend/app/routers/debuglog_router.py:151

  • The return statement has a third empty list parameter, but the function signature suggests it should only return two values (success boolean and failed_pods list).
                                    dependencies.append(target_pod.metadata.name)

@wanhakim wanhakim requested a review from siawchen August 1, 2025 09:47
Copy link
Collaborator

@siawchen siawchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@siawchen siawchen merged commit 0a5ddae into opea-project:main Aug 2, 2025
4 of 5 checks passed
wanhakim added a commit to wanhakim/GenAIStudio that referenced this pull request Aug 6, 2025
* update sandbox run error handling and fixes for docsum and codegen workflows (opea-project#69)

* update setup playbooks

Signed-off-by: wwanarif <[email protected]>

* debuglogs to display the connections between pods

Signed-off-by: wwanarif <[email protected]>

* fix chat history bug and duplicate workflow bug

Signed-off-by: wwanarif <[email protected]>

* fix genai-studio ansible to include create-ssh-secrets playbook

Signed-off-by: wwanarif <[email protected]>

* update to sandbox run error handling

Signed-off-by: wwanarif <[email protected]>

* fix for docum and codegen workflows

Signed-off-by: wwanarif <[email protected]>

---------

Signed-off-by: wwanarif <[email protected]>

* fix for agent think card

1. filter tool call in final output
2. if streaming response in progress, keep showing response is generating message
3. if final output no answer, print iteration limit reached without final answer

Signed-off-by: cheehook <[email protected]>

* Revert "Merge branch 'main' into agentqna_ui_fix"

This reverts commit fe0d83c, reversing
changes made to 27f8d63.

* Revert "Revert "Merge branch 'main' into agentqna_ui_fix""

This reverts commit a0e1cd5.

* fix wrongly merge conflict

---------

Signed-off-by: wwanarif <[email protected]>
Signed-off-by: cheehook <[email protected]>
Co-authored-by: wanhakim <[email protected]>
siawchen pushed a commit that referenced this pull request Aug 13, 2025
* update setup playbooks

Signed-off-by: wwanarif <[email protected]>

* debuglogs to display the connections between pods

Signed-off-by: wwanarif <[email protected]>

* fix chat history bug and duplicate workflow bug

Signed-off-by: wwanarif <[email protected]>

* fix genai-studio ansible to include create-ssh-secrets playbook

Signed-off-by: wwanarif <[email protected]>

* update to sandbox run error handling

Signed-off-by: wwanarif <[email protected]>

* fix for docum and codegen workflows

Signed-off-by: wwanarif <[email protected]>

* temporary hardcoding agent comp image to v1.3

Signed-off-by: wwanarif <[email protected]>

* Agentqna UI fix (#18)

* update sandbox run error handling and fixes for docsum and codegen workflows (#69)

* update setup playbooks

Signed-off-by: wwanarif <[email protected]>

* debuglogs to display the connections between pods

Signed-off-by: wwanarif <[email protected]>

* fix chat history bug and duplicate workflow bug

Signed-off-by: wwanarif <[email protected]>

* fix genai-studio ansible to include create-ssh-secrets playbook

Signed-off-by: wwanarif <[email protected]>

* update to sandbox run error handling

Signed-off-by: wwanarif <[email protected]>

* fix for docum and codegen workflows

Signed-off-by: wwanarif <[email protected]>

---------

Signed-off-by: wwanarif <[email protected]>

* fix for agent think card

1. filter tool call in final output
2. if streaming response in progress, keep showing response is generating message
3. if final output no answer, print iteration limit reached without final answer

Signed-off-by: cheehook <[email protected]>

* Revert "Merge branch 'main' into agentqna_ui_fix"

This reverts commit fe0d83c, reversing
changes made to 27f8d63.

* Revert "Revert "Merge branch 'main' into agentqna_ui_fix""

This reverts commit a0e1cd5.

* fix wrongly merge conflict

---------

Signed-off-by: wwanarif <[email protected]>
Signed-off-by: cheehook <[email protected]>
Co-authored-by: wanhakim <[email protected]>

* fix UI choice on sandbox app launch, clean up printouts and fix compose

Signed-off-by: wwanarif <[email protected]>

* enhance click deploy flow

Signed-off-by: wwanarif <[email protected]>

* update app fe's Summarize Content view

Signed-off-by: wwanarif <[email protected]>

* fix caching issues in studio's nginx

Signed-off-by: wwanarif <[email protected]>

* added playright tests for docsum and codegen

Signed-off-by: wwanarif <[email protected]>

* fixing bugs and enhancing clickdeploy experience

Signed-off-by: wwanarif <[email protected]>

* fix docsum and eventstreaming in compose deployment

Signed-off-by: wwanarif <[email protected]>

* fix api call bugs and updated data management web files display

Signed-off-by: wwanarif <[email protected]>

* updated test file for little red riding hood typo

Signed-off-by: wwanarif <[email protected]>

---------

Signed-off-by: wwanarif <[email protected]>
Signed-off-by: cheehook <[email protected]>
Co-authored-by: cheehook <[email protected]>
@siawchen siawchen added this to the v1.4 milestone Aug 13, 2025
@siawchen siawchen linked an issue Aug 20, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sandbox status becomes error after deploying LLM/ChartQnA templates

2 participants