refactor: consolidate Firebase deployment steps into reusable workflow

[mafreud]

Summary by CodeRabbit

• チョア
  • Firebase Functions のデプロイ手順を再利用可能なワークフローに統合し、重複を排除。
  • 開発／本番環境のシークレット命名を整理し、環境ごとの設定を明確化。
  • CI 内でのビルド・テスト・デプロイのフローを共通化し、信頼性と可視性を向上。ユーザー向け機能の変更はありません。

[linear]

OP-299 Refactor CI

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

既存のFirebase Functionsデプロイ手順を共通の再利用可能ワークフローに集約。github-apps-cd.ymlのdev/productionジョブは新規reusable-deploy-firebase-functions.ymlを呼び出し、環境ごとのシークレット名を再マッピング。チェックアウト／Node設定／認証／ビルド／テスト／デプロイは共通ワークフローへ移動。

Changes

Cohort / File(s)	Change Summary
GitHub Actions: CDワークフロー呼び出し変更 \.github/workflows/github-apps-cd.yml	dev/prodジョブのインライン手順を削除し、新規再利用可能ワークフローを呼び出すように変更。devはGHA_SERVICE_ACCOUNT_PREVIEW_FUNCS→gha_service_account、FIREBASE_PROJECT_ID_FOR_PREVIEW_FUNCTIONS→firebase_project_idにマップ。prodはGHA_SERVICE_ACCOUNT/FIREBASE_PROJECT_IDをマップ。
GitHub Actions: 再利用可能ワークフロー追加 \.github/workflows/reusable-deploy-firebase-functions.yml	Firebase Functions用の再利用可能ワークフローを追加。必須シークレットgha_service_account/firebase_project_idを定義し、openci-runner/firebase/functionsを作業ディレクトリにして checkout → Nodeセットアップ（.nvmrc）→google-github-actions/auth（credentials_json）→npm ci→npm run build→npm test→firebase-toolsでデプロイを実行。

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Dev as Developer
  participant GH as GitHub Actions\n(github-apps-cd.yml)
  participant RW as Reusable Workflow\n(reusable-deploy-firebase-functions.yml)
  participant Auth as Google Auth
  participant FB as Firebase Project

  Dev->>GH: push/merge (dev or prod)
  GH->>RW: invoke (secrets: gha_service_account, firebase_project_id)
  RW->>RW: checkout → setup-node(.nvmrc) → npm ci → build → test
  RW->>Auth: google-github-actions/auth (credentials_json)
  Auth-->>RW: auth token
  RW->>FB: firebase-tools deploy --project ${firebase_project_id}
  FB-->>RW: deploy result
  RW-->>GH: job status
  GH-->>Dev: workflow result

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Refactor CI #461: 同様にFirebase Functionsのデプロイ手順を再利用可能ワークフローへ移行する変更と関連。
• refactor: streamline GitHub Actions workflows and remove unnecessary paths #460: Node設定と再利用可能ワークフロー化に関する修正が重なるため関連。
• fix: update Firebase service account secret in GitHub Actions workflow #473: github-apps-cd.yml内のGoogle認証用シークレット名変更に直接関連する変更。

Poem

ぴょんと跳ねて、ワークフローをひとまとめ
シークレットはそっと箱へお引っ越し
ビルドとテストを並べてパレード🎶
雲へ放つ関数、道筋は一筆書き
にんじん片手に、デプロイお祝いだよ 🥕🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	タイトルはFirebaseデプロイ手順を再利用可能なワークフローに統合するという本変更の主旨を簡潔かつ明確に示しており、不要な情報や曖昧さもなく適切です。
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f8336b1 and 91f068e.

📒 Files selected for processing (1)

• .github/workflows/github-apps-cd.yml (1 hunks)

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4f7d52e and f8336b1.

📒 Files selected for processing (2)

• .github/workflows/github-apps-cd.yml (1 hunks)
• .github/workflows/reusable-deploy-firebase-functions.yml (1 hunks)

🧰 Additional context used

🪛 actionlint (1.7.7)

.github/workflows/github-apps-cd.yml

12-12: reusable workflow call ".github/workflows/reusable-deploy-firebase-functions.yml" at "uses" is not following the format "owner/repo/path/to/workflow.yml@ref" nor "./path/to/workflow.yml". see https://docs.github.com/en/actions/learn-github-actions/reusing-workflows for more details

(workflow-call)

---

19-19: reusable workflow call ".github/workflows/reusable-deploy-firebase-functions.yml" at "uses" is not following the format "owner/repo/path/to/workflow.yml@ref" nor "./path/to/workflow.yml". see https://docs.github.com/en/actions/learn-github-actions/reusing-workflows for more details

(workflow-call)