feat: include username in event data#280
Open
BryanttV wants to merge 3 commits intoopen-craft:masterfrom
Open
Conversation
c0d2d16 to
6c91602
Compare
6c91602 to
5d89c4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
usernamefield to the data of the events.Motivation
Currently, the events emitted by openedx-completion-aggregator only include the user_id, which creates a significant limitation for integration scenarios with external services.
According to the Open edX Events documentation regarding integration with external systems,
TRACKING_EVENT_EMITTEDevents are sent through the event bus to be consumed by third-party services. The issue is that with only theuser_idavailable in the event, external consumers face an incomplete workflow.This change follows the existing pattern used in Open edX, where events include the
username:Testing Instructions
Using Tutor:
usernamefield.Merge Checklist