Skip to content

feat: include username in event data #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BryanttV wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: include username in event data #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a2b422
feat: include username in aggregator event data
BryanttV Jan 27, 2026
ad9b971
test: add username in assert of event
BryanttV Jan 27, 2026
5d89c4d
chore: add username field in event data fixtures
BryanttV Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions completion_aggregator/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ def emit_completion_aggregator_logs(updated_aggregators):
event_name,
{
"user_id": aggregator.user_id,
"username": aggregator.user.username,
"course_id": str(aggregator.course_key),
"block_id": str(aggregator.block_key),
"modified": aggregator.modified,
Expand Down
3 changes: 2 additions & 1 deletion tests/fixtures/raw/openedx.completion_aggregator.progress.chapter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"timestamp": "2023-12-05T21:34:52.909063+00:00",
"data": {
"user_id": 4,
"username": "openedx",
"course_id": "course-v1:edX+DemoX+Demo_Course",
"context_key": "course-v1:edX+DemoX+Demo_Course",
"block_id": "block-v1:edX+DemoX+Demo_Course+type@chapter+block@b443e0d6bc4d43c1bed991dbd8a10d42",
Expand All @@ -15,7 +16,7 @@
"course_id": "course-v1:edX+DemoX+Demo_Course",
"course_user_tags": {},
"session": "056aca2a1c6b76742b283e73d3424453",
"user_id": 3,
"user_id": 4,
"username": "openedx",
"ip": "172.18.0.1",
"host": "localhost:18000",
Expand Down
3 changes: 2 additions & 1 deletion tests/fixtures/raw/openedx.completion_aggregator.progress.course.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"timestamp": "2023-12-05T21:34:52.909063+00:00",
"data": {
"user_id": 4,
"username": "openedx",
"course_id": "course-v1:edX+DemoX+Demo_Course",
"context_key": "course-v1:edX+DemoX+Demo_Course",
"block_id": "block-v1:edX+DemoX+Demo_Course+type@course+block@course",
Expand All @@ -15,7 +16,7 @@
"course_id": "course-v1:edX+DemoX+Demo_Course",
"course_user_tags": {},
"session": "056aca2a1c6b76742b283e73d3424453",
"user_id": 3,
"user_id": 4,
"username": "openedx",
"ip": "172.18.0.1",
"host": "localhost:18000",
Expand Down
3 changes: 2 additions & 1 deletion tests/fixtures/raw/openedx.completion_aggregator.progress.sequential.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"timestamp": "2023-12-05T21:34:52.909063+00:00",
"data": {
"user_id": 4,
"username": "openedx",
"course_id": "course-v1:edX+DemoX+Demo_Course",
"context_key": "course-v1:edX+DemoX+Demo_Course",
"block_id": "block-v1:edX+DemoX+Demo_Course+type@sequential+block@bf1eac10ebb649e3aaf9cc07325f8e04",
Expand All @@ -15,7 +16,7 @@
"course_id": "course-v1:edX+DemoX+Demo_Course",
"course_user_tags": {},
"session": "056aca2a1c6b76742b283e73d3424453",
"user_id": 3,
"user_id": 4,
"username": "openedx",
"ip": "172.18.0.1",
"host": "localhost:18000",
Expand Down
3 changes: 2 additions & 1 deletion tests/fixtures/raw/openedx.completion_aggregator.progress.vertical.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"timestamp": "2023-12-05T21:34:52.909063+00:00",
"data": {
"user_id": 4,
"username": "openedx",
"course_id": "course-v1:edX+DemoX+Demo_Course",
"context_key": "course-v1:edX+DemoX+Demo_Course",
"block_id": "block-v1:edX+DemoX+Demo_Course+type@vertical+block@e1fabd9fa55f441caa75580f258ffbc3",
Expand All @@ -15,7 +16,7 @@
"course_id": "course-v1:edX+DemoX+Demo_Course",
"course_user_tags": {},
"session": "056aca2a1c6b76742b283e73d3424453",
"user_id": 3,
"user_id": 4,
"username": "openedx",
"ip": "172.18.0.1",
"host": "localhost:18000",
Expand Down
1 change: 1 addition & 0 deletions tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ def assert_emit_method_called(self, obj):
f"openedx.completion_aggregator.progress.{obj.aggregation_name}",
{
"user_id": obj.user_id,
"username": obj.user.username,
"course_id": str(obj.course_key),
"block_id": str(obj.block_key),
"modified": obj.modified,
Expand Down