Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Portuguese Glossary version #81

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

samueltauil
Copy link
Contributor

Signed-off-by: Samuel Tauil [email protected]

Related to #77

Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samueltauil 🙌

I can't review the language translation itself, but I know there were accompanying changes in PRINCIPLES.md that also need to be added to each translation.

Please make sure to do the actual translation from current main instead of from a single PR, because there were several fixes (see my note in #77).

@samueltauil
Copy link
Contributor Author

@scottrigby fix done, we might want a second Portuguese speaker to review these changes

i18n/PRINCIPLES_pt.md Outdated Show resolved Hide resolved
i18n/PRINCIPLES_pt.md Outdated Show resolved Hide resolved
i18n/GLOSSARY_pt.md Outdated Show resolved Hide resolved
i18n/GLOSSARY_pt.md Outdated Show resolved Hide resolved
i18n/GLOSSARY_pt.md Outdated Show resolved Hide resolved
@todaywasawesome todaywasawesome added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Sep 4, 2024
@todaywasawesome
Copy link
Member

@samueltauil Hey, can we get these resolved so we can move forward? Do you need additional help or reviewers?

@samueltauil
Copy link
Contributor Author

@todaywasawesome @makkes could you guys do a quick review to see if everything looks good to be merged?

@JaimeMagiera
Copy link

@makkes @samueltauil This needs a review approval. Is it ready to move forward?

@samueltauil
Copy link
Contributor Author

samueltauil commented Oct 16, 2024 via email

@makkes
Copy link
Member

makkes commented Oct 18, 2024

@makkes @samueltauil This needs a review approval. Is it ready to move forward?

Yep, I already gave my 👍🏻.

@todaywasawesome todaywasawesome merged commit 1939866 into open-gitops:main Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed translation review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants