-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Portuguese Glossary version #81
Update Portuguese Glossary version #81
Conversation
Signed-off-by: Samuel Tauil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @samueltauil 🙌
I can't review the language translation itself, but I know there were accompanying changes in PRINCIPLES.md that also need to be added to each translation.
Please make sure to do the actual translation from current main
instead of from a single PR, because there were several fixes (see my note in #77).
Signed-off-by: Samuel Tauil <[email protected]>
@scottrigby fix done, we might want a second Portuguese speaker to review these changes |
@samueltauil Hey, can we get these resolved so we can move forward? Do you need additional help or reviewers? |
Signed-off-by: Samuel Tauil <[email protected]>
@todaywasawesome @makkes could you guys do a quick review to see if everything looks good to be merged? |
@makkes @samueltauil This needs a review approval. Is it ready to move forward? |
ready to merge from my perspective
…On Wed, Oct 16, 2024 at 15:22 Jaime Magiera ***@***.***> wrote:
@makkes <https://github.com/makkes> @samueltauil
<https://github.com/samueltauil> This needs a review approval. Is it
ready to move forward?
—
Reply to this email directly, view it on GitHub
<#81 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACEFTW6TFOBFEFLSGDJTZLZ324IRAVCNFSM6AAAAABMIWJ2EGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJXG42TENRSGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yep, I already gave my 👍🏻. |
Signed-off-by: Samuel Tauil [email protected]
Related to #77