-
Notifications
You must be signed in to change notification settings - Fork 67
Issue1473 pvt validation ext #1481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LoneMeertens
wants to merge
87
commits into
master
Choose a base branch
from
issue1473_PvtValidationExt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 73 commits
Commits
Show all changes
87 commits
Select commit
Hold shift + click to select a range
d666bf9
Merge branch 'master' of github.com:open-ideas/IDEAS
LoneMeertens 35b6c1a
feat: add modified PV model in BaseClasses of PVT validation
LoneMeertens 4ae0adf
refactor: read inputs from meaDat instead of sim
LoneMeertens 29f7660
refactor: change naming conventions
LoneMeertens 495fa0d
docs: add documentation to ElectricalPV validation model
LoneMeertens 1180546
refactor: fix error in parameter propagation
LoneMeertens b2eed38
feat: add ElectricalPV model for PVT UN validation
LoneMeertens ee843fd
feat: add ElectricalPV model and output expr to Electrical validation…
LoneMeertens 00c7b7c
refactor: add expr for P output ElectricalPV for UI PVT validation
LoneMeertens 6d47bc9
refactor: change naming of parameters following convention.
LoneMeertens 6f0e09c
feat: add new data files for validation where heat losses of c3, c4 a…
LoneMeertens fb3387a
feat: structure validation models to output simulation variables
LoneMeertens 2e145d9
refactor: make additional BaseClasses folders to keep conventional st…
LoneMeertens 216e174
factor: validation model for UN collector
LoneMeertens 8264c3b
refactor: make sure Tcell is in deg Celcius
LoneMeertens 4fc29f8
feat: include expression for Tcell
LoneMeertens 4506332
feat: adding c7 and c8 to generic data sheet to switch from ISO 9806 …
LoneMeertens 840e1c7
refactor: change genericQuasiDynamic to Generic since ISO 9806 2017 a…
LoneMeertens 81bb14d
feat: update all data records to have 8 term format
LoneMeertens bb1bb14
refactor: heaLosStc in PVTCollector model to include a7 and a8 loss t…
LoneMeertens f14156e
refactor: rename PVTQuasiDynamicCollector to PVTCollector since new s…
LoneMeertens 9c7f222
refactor: include a7 and a8 terms in heat loss calculation and modify…
LoneMeertens db34925
refactor: HeatLoss test example adapt wind speed amplitude to not bec…
LoneMeertens a275b9f
refactor: rename ISO9806QuasiDynamicHeatLoss to ISO9806HeatLoss since…
LoneMeertens 5074916
refactor: adapt UAbsFluid calculation in ElectricalPVT by changing c1…
LoneMeertens 72c9918
refactor: PVT_UI validation to include additional loss terms
LoneMeertens d24fa28
refactor: renaming PVT validation collector model and submodels (remo…
LoneMeertens 7ee23f4
refactor: updating UN PVT validation model and submodels to use ISO98…
LoneMeertens 7e80da3
refactor: modify coefficients for state-of-the-art model following Er…
LoneMeertens cb1d1c3
refactor: calculate Kd based on ISO Annex B.3 - B.5, also influences …
LoneMeertens e831d9d
refactor: error in eta0 conversion from 2013 to 2017 standard
LoneMeertens f67dcb4
refactor: correct for too low Kd and set number of segment to default
LoneMeertens 916a7d8
refactor: change Kd to detailed annex B ISO 9806 2017 method
LoneMeertens 55a8d56
docs: update user guide
LoneMeertens 7c30f64
docs: update PVTCollector model documentation
LoneMeertens a11c2d9
docs: update Data package
LoneMeertens 2ac3b8e
docs: full PVTCollectors package updated
LoneMeertens c08aa29
feat: add excel format conversion template in corresponding Resources…
LoneMeertens 6a327a1
docs: update reference paper title
LoneMeertens 87767c4
fix + docs: remove break to be compatible with OM, update docs to exp…
LoneMeertens 4589aec
refactor: update UAbsFluid formulation, assuming electrical power ind…
LoneMeertens b4de0f2
fix: redo parameter removed
LoneMeertens f2de868
docs: update revision
LoneMeertens c07afa5
refactor: change gamma to beta to be consitent with paper
LoneMeertens afdd4ba
docs: update title journal paper in references
LoneMeertens 4fae5d1
refactor: unit convetions
LoneMeertens 5fdcf48
docs: update docs
LoneMeertens e7f4f77
docs: update docs
LoneMeertens be272d4
refactor: fix unit inconsistency
LoneMeertens c883f1b
docs: update docs
LoneMeertens a3f3cde
refactor: remove obsolute whitespaces
LoneMeertens d980770
docs: update revisions
LoneMeertens 5d069e3
docs: update documentation strings
LoneMeertens a38aae9
refactor: rename variables following conventions
LoneMeertens 30906ad
docs: update docs
LoneMeertens e16a5bd
refactor: adapting naming conventions
LoneMeertens 8f10b82
docs: update comment strings
LoneMeertens 7545bcf
docs: group documentation in main PVT_UI package
LoneMeertens 1baaff9
docs: move docs to PVT_UI top level package and refer to paper for re…
LoneMeertens a95c38c
docs: update docs
LoneMeertens 7bd5609
refactor: correct paths
LoneMeertens 707a243
docs: updated docs and figure in user guide
LoneMeertens e65cee0
refactor: merge two ElectricalPV models in one common PV model
LoneMeertens f305f77
refactor: restructure ElectricalPV validation
LoneMeertens 78f56b9
refactor: PVTCollectorValidation UI and UN extend from partial type
LoneMeertens e77732d
feat: extend all electrical validation from base model
LoneMeertens acc97a3
feat: extend all thermal validation model form one base model
LoneMeertens 730298d
refactor: update conventions and documetation strings
LoneMeertens aab9ccc
docs: update revisions
LoneMeertens c9ba05b
refactor: update package order
LoneMeertens 89e9963
test: update reference results unit test
LoneMeertens aa5a887
test: test Baseclasses Example only for PVTCollecters package unit test
LoneMeertens 72ce344
test: generate new reference results
LoneMeertens a8d197e
refactor: remove obsolete parameter
LoneMeertens 86141f9
refactor: remove obsolete whitespace
LoneMeertens 08581c2
docs: update documentation
LoneMeertens cb82d58
refactor: remove absolete white space
LoneMeertens f1dcab8
docs: update documentation reference section
LoneMeertens 10c78af
refactor: update paths to full path
LoneMeertens 4474fd9
docs: update documentation
LoneMeertens 7180b07
docs: update docs
LoneMeertens feaa0ea
docs: update docs
LoneMeertens 3750b4c
docs: udpate docs
LoneMeertens bf8b257
docs: add description and revision history analog to thermal model
LoneMeertens 99b3788
refactor: make PVT collector itself replaceable
LoneMeertens b8ef682
refactor: make data record replaceable
LoneMeertens 9557e7b
refactor: make data record and pvt model replaceable
LoneMeertens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.